Dublin Core metadata is used by several file formats, e.g. ODF,
MS Office 2007 (Office XML) and SVG. Add a helper which can be
used by the extractors.
Details
Details
- Reviewers
astippich - Group Reviewers
Frameworks - Commits
- R286:1b242697d27d: [KFileMetaData] Add helper for XML encoded Dublin Core metadata
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I guess you plan to convert the existing extractors to use this?
The only concern I might have that now two iterations over the node are required when this is used in e.g. odfextractor, isn't it?
Btw, I don't think it's necessary to prepend KFileMetaData in the diff title, since the repository is only for KFileMetaData anyway.
Comment Actions
Yes, thats the plan
The only concern I might have that now two iterations over the node are required when this is used in e.g. odfextractor, isn't it?
The QDomDocument can be reused, so parsing is only done once. Iteration needs to be done twice, but this is only a minor issue as the metadata documents are really small (~10 nodes, 1kByte). For the office2007extractor it actually is a win, as it currently iterates the tree once per property.