Differential D16533

Add editorconfig file
ClosedPublic
Actions

Authored by nicolasfella on Oct 30 2018, 7:53 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:bf03990b75f0: Add editorconfig file
Summary

editorconfig is a cross-editor way of keeping basic coding style standards, e.g. indentation

Diff Detail

Repository
R224 KDE Connect
Branch
editorconfig
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4353
Build 4371: arc lint + arc unit
nicolasfella created this revision.Oct 30 2018, 7:53 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 30 2018, 7:53 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Oct 30 2018, 7:53 PM
nicolasfella added a reviewer: KDE Connect.Oct 30 2018, 7:53 PM
nicolasfella edited the summary of this revision. (Show Details)
nicolasfella updated this revision to Diff 44511.Oct 30 2018, 7:54 PM
  • Remove comment
sredman added a subscriber: sredman.Oct 30 2018, 8:13 PM

I like this, but I am going to give a little bit of time for anyone who wants to make an argument for tabs

My argument for spaces:
Anyone might have their editor set up to display tabs differently. Yours might show as 8, mine might show as 4, etc. If you try to use tabs to align multi-line blocks, it ends up looking terrible. If the editor is configured to use spaces instead of tabs, everything is consistent

albertvaka accepted this revision.Oct 31 2018, 9:57 AM
albertvaka added a subscriber: albertvaka.

This was the "implicit" style anyway.

This revision is now accepted and ready to land.Oct 31 2018, 9:57 AM
Closed by commit R224:bf03990b75f0: Add editorconfig file (authored by nicolasfella). · Explain WhyOct 31 2018, 3:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AM.editorconfig (9 lines)

Diff 44511

View Options

.editorconfig

Loading...