[Extractor] Do not check QFile::exists for an empty url
ClosedPublic
Actions

Authored by bruns on Oct 30 2018, 2:22 AM.

Details

Reviewers

dfaure
apol
broulik

Group Reviewers

Baloo
Frameworks

Commits

R293:856fd6811881: [Extractor] Do not check QFile::exists for an empty url

Summary

In case the file has been removed from the IdTree DB, but is still in the
IndexingLevelDB, documentUrl(id) may return an empty name. Skip the
check if the name isEmpty().

Qt 5.10 issues a runtime warning otherwise - 'Empty filename passed to
function'.

Diff Detail

Repository

R293 Baloo

Branch

extractor

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4334
Build 4352: arc lint + arc unit

bruns created this revision.Oct 30 2018, 2:22 AM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 30 2018, 2:22 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

bruns requested review of this revision.Oct 30 2018, 2:22 AM

Harbormaster completed remote builds in B4334: Diff 44475.Oct 30 2018, 2:22 AM

broulik accepted this revision.Oct 30 2018, 2:41 AM

This revision is now accepted and ready to land.Oct 30 2018, 2:41 AM

Closed by commit R293:856fd6811881: [Extractor] Do not check QFile::exists for an empty url (authored by bruns). · Explain WhyOct 30 2018, 4:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/file/extractor/app.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44475	b134533		Oct 30 2018, 2:22 AM	★	★
Diff 2	44480	b134533	R293:856fd68118817d3c8807e3e6286ffb1e059907a0	Oct 30 2018, 3:40 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a08a19e4274d	fc4b61505faa	b13453360685	Stefan Brüns	[Extractor] Do not check QFile::exists for an empty url (Show More…)	Oct 30 2018, 1:59 AM

Diff 44475

View Options

src/file/extractor/app.cpp