Differential D16465

[KSambaShare] Make "net usershare info" parser testable
ClosedPublic
Actions

Authored by bruns on Oct 27 2018, 5:44 PM.

Details

Reviewers
broulik
apol
Group Reviewers
Frameworks
Commits
R241:253d58f6734e: [KSambaShare] Make "net usershare info" parser testable
Summary

KSambaSharePrivate::sync() reads from the runtime environment of the user
and modifies the the share list in place.

Split out the parser part, and create a fresh share list from the input,
which replaces the old list after parsing.

Test Plan

make && ctest
no functional changes

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Oct 27 2018, 5:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 27 2018, 5:44 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Oct 27 2018, 5:44 PM
bruns retitled this revision from [KSambaShare] Make "net usershare list" parser testable to [KSambaShare] Make "net usershare info" parser testable.Oct 27 2018, 5:52 PM
apol added a subscriber: apol.Nov 2 2018, 11:39 PM

I'm confused, you didn't add a test?

bruns added a comment.Nov 3 2018, 3:10 AM
In D16465#353081, @apol wrote:

I'm confused, you didn't add a test?

See stack

apol accepted this revision.Nov 4 2018, 1:15 AM
This revision is now accepted and ready to land.Nov 4 2018, 1:15 AM
Closed by commit R241:253d58f6734e: [KSambaShare] Make "net usershare info" parser testable (authored by bruns). · Explain WhyNov 4 2018, 1:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/ksambashare.cpp (29 lines)
Msrc/core/ksambashare_p.h (2 lines)

Diff 44810

View Options

src/core/ksambashare.cpp

Loading...
View Options

src/core/ksambashare_p.h

Loading...