[KSambaShare] Trim trailing / from share path
ClosedPublic

Authored by bruns on Sat, Oct 27, 5:42 PM.

Details

Summary

When adding usershares manually on the command line, it is common to
have a path with trailing "/" due to tab completion. Samba treats paths
with and without / the same, but KIO does not pick up these shares.

These folder paths are not marked in e.g. dolphin as shared and can not
be edited properly.

Test Plan

make && ctest
open directory with shared folders in dolphin, also share with trailing / in path= show up

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Sat, Oct 27, 5:42 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSat, Oct 27, 5:42 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Sat, Oct 27, 5:42 PM
bruns edited the test plan for this revision. (Show Details)Sat, Oct 27, 5:54 PM
broulik accepted this revision.Sun, Oct 28, 3:19 PM
This revision is now accepted and ready to land.Sun, Oct 28, 3:19 PM
This revision was automatically updated to reflect the committed changes.
aacid added a subscriber: aacid.Sun, Oct 28, 5:27 PM

In case you didn't see it, you broke compilation with Qt 5.9

bruns added a comment.Sun, Oct 28, 5:37 PM

In case you didn't see it, you broke compilation with Qt 5.9

Should be fixed:
https://commits.kde.org/kio/9eb7e24aeb993f48d95b9dd4f6a3c18c33402f92