[effects/desktopgrid] Specify screen projection matrix when drawing moving window

Authored by ekurzinger on Oct 25 2018, 10:06 PM.



Currently, when the user is moving a window in the desktop grid it is drawn from the paintScreen function to ensure it appears above all other windows. However, when drawing the window, the screenProjectionMatrix for the WindowPaintData structure is never specified. Because of this, the window will not be visible if OpenGL compositing along with Lanczos scaling are in use since its coordinates will never be projected into screen-space (unless the window is maximized, in which case the scaling code is bypassed).

BUG: 361371
BUG: 364509

FIXED-IN: 5.14.3

Test Plan

Ensure OpenGL compositing is enabled and the scaling method is set to "Accurate" on hardware supporting this option. Additionally, ensure the desktop grid effect is active and is configured to use Present Windows. Open a window and ensure is it not maximized. Click on the window and drag it around - its contents should remain visible the entire time and follow the mouse.

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ekurzinger created this revision.Oct 25 2018, 10:06 PM
Restricted Application added a subscriber: kwin. · View Herald TranscriptOct 25 2018, 10:06 PM
ekurzinger requested review of this revision.Oct 25 2018, 10:06 PM
davidedmundson accepted this revision.Oct 26 2018, 12:40 AM
davidedmundson added a subscriber: davidedmundson.

Thanks, good stuff!

This revision is now accepted and ready to land.Oct 26 2018, 12:40 AM

Hi David, thanks for taking a look! Note that I haven't got commit access so I believe someone will need to merge on my behalf. For authorship information, my name is Erik Kurzinger and email is ekurzinger@nvidia.com.

Looks like a simple enough patch for 5.14.3 rather than 5.15?

zzag accepted this revision.Oct 26 2018, 7:52 AM
zzag added a comment.Oct 26 2018, 8:17 AM

Looks like a simple enough patch for 5.14.3 rather than 5.15?

Yep, I don't see any reason why it can't go in 5.14.3. :-)

zzag edited the summary of this revision. (Show Details)Oct 26 2018, 8:17 AM
This revision was automatically updated to reflect the committed changes.