Update KImageMapEditor icons
ClosedPublic

Authored by yurchor on Oct 24 2018, 5:31 PM.

Details

Summary

Simpler colors, same idea. Maybe they are awful (I'm not a painter). Just trying to revive it and show a bit more modern non-pixelated look.

Test Plan

Old:

New:

Diff Detail

Repository
R443 KImageMapEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor requested review of this revision.Oct 24 2018, 5:31 PM
yurchor created this revision.
ngraham added a reviewer: VDG.Oct 24 2018, 5:52 PM
ngraham added a subscriber: ngraham.

The new ones look better to me!

Much better that what I would ever do as artist, thanks.
The only think that I think it can be improved is the "<map>" text: a bold version could it make it more visible.

yurchor updated this revision to Diff 44168.EditedOct 24 2018, 6:34 PM

Make <map> bold.

Looks better, thanks! Let's see if the VDG has anything to say, otherwise I will approve it.

aacid added a subscriber: aacid.Oct 25 2018, 8:41 PM

Personally i think it'd be good if we could make the small ones a bit more "pixellated", they look a bit blurry (specially the third from the left) and it seems like we could "fake" the hand to be seen a bit better.

But as Luigi says, they do look nice and better than i would make it so don't consider this a blocker :)

yurchor updated this revision to Diff 44234.Oct 26 2018, 5:30 AM

Fix broken patch.

abetts added a subscriber: abetts.Oct 26 2018, 2:16 PM

My only comment is that the background for the globe has colors that are too close to each other, maybe a little too dull. I would recommend brightening them up a little bit.

yurchor updated this revision to Diff 44254.EditedOct 26 2018, 3:00 PM

A bit brighter color scheme. Low resolutions are painted by mesh to avoid blurring.

A bit brighter color scheme. Low resolutions are painted by mesh to avoid blurring.

Thanks for doing that. I think it looks more balanced that way. +1

aacid added a comment.Oct 26 2018, 7:14 PM

Looks nice!

@ltoscano will you give the final "approve"?

ltoscano accepted this revision as: ltoscano.Oct 26 2018, 7:15 PM

Thanks a lot!

This revision is now accepted and ready to land.Oct 26 2018, 7:15 PM
This revision was automatically updated to reflect the committed changes.