Differential D16287

[Comics & Weather widgets] give "Configure..." buttons icons
ClosedPublic
Actions

Authored by ngraham on Oct 17 2018, 11:10 PM.

Details

Reviewers
kossebau
davidedmundson
Group Reviewers
Plasma
Commits
R114:bd558d122885: [Comics & Weather widgets] give "Configure..." buttons icons
Summary

This patch gives the Comics and Weather widgets appropriate icons for their Configure... buttons.

BUG: 399888
FIXED-IN: 5.14.2

Test Plan


(Weather on top, Comics on bottom)

Note that the size discrepancy appears to be an unrelated PlasmaComponents3 bug: https://bugs.kde.org/show_bug.cgi?id=399952 (The Weather widget uses PC3, while the Comics widget uses PC2)

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 17 2018, 11:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 17 2018, 11:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 17 2018, 11:10 PM
ngraham edited the test plan for this revision. (Show Details)Oct 17 2018, 11:11 PM
kossebau added a comment.Oct 17 2018, 11:29 PM

Not exactly sure, but:

Icons for buttons might be a newer property than the min one for kdeplasma-addons 5.14 (which seems KF 5.50):

The property seems only present since KF 5.51: https://phabricator.kde.org/R242:85cab5772c560ea248c490d9d58db87296dec06b

Too bad properties as documented on https://api.kde.org/frameworks/plasma-framework/html/classorg_1_1kde_1_1plasma_1_1components_1_1Button.html do not have "Since" comments on them.

So chance is this fix can be only done for master/Plasma 5.15.

No time for deeper inspection right now myself, please check.

ngraham added a subscriber: mart.Oct 18 2018, 2:55 AM

Nice catch, it looks like that's exactly right. Rebasing on master.

@mart, any thoughts on https://bugs.kde.org/show_bug.cgi?id=399952?

ngraham updated this revision to Diff 43831.Oct 18 2018, 2:55 AM

Rebase on master

ngraham updated this revision to Diff 43832.Oct 18 2018, 2:59 AM

Do that correctly

davidedmundson accepted this revision.Oct 18 2018, 8:31 AM
This revision is now accepted and ready to land.Oct 18 2018, 8:31 AM
Closed by commit R114:bd558d122885: [Comics & Weather widgets] give "Configure..." buttons icons (authored by ngraham). · Explain WhyOct 18 2018, 12:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43865

View Options

applets/comic/package/contents/ui/main.qml

Loading...
View Options

applets/weather/package/contents/ui/FullRepresentation.qml

Loading...