Make separators in FindDevicesPage visually distinctive
Needs RevisionPublic

Authored by nicolasfella on Oct 17 2018, 10:53 PM.

Details

Reviewers
ngraham
Group Reviewers
KDE Connect
VDG
Summary

Also give the text a slight padding

Test Plan

Before

After

Diff Detail

Repository
R224 KDE Connect
Branch
headercolor (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4008
Build 4026: arc lint + arc unit
nicolasfella created this revision.Oct 17 2018, 10:53 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 17 2018, 10:53 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Oct 17 2018, 10:53 PM
nicolasfella edited the test plan for this revision. (Show Details)Oct 17 2018, 10:54 PM
apol added a subscriber: apol.Oct 17 2018, 11:02 PM

How about changing the level? I have the feeling that changing the color isn't the solution here.

Left is now, right is heading increased by 1.

One way or the other I think the color is a nice touch

Looks great to me. I would probably follow closely what Discover is doing with their headers. @ngraham could give you some info on that. Or if you take a look at the sources page within Discover, you will see what I mean.

apol added a comment.Oct 24 2018, 10:58 PM

What we do in Discover.

GB_2 added a subscriber: GB_2.Sep 28 2019, 8:03 AM

Use the new Kirigami ListSectionHeader.

ngraham requested changes to this revision.Sep 28 2019, 1:54 PM
In D16286#539051, @GB_2 wrote:

Use the new Kirigami ListSectionHeader.

^^ That. :)

This revision now requires changes to proceed.Sep 28 2019, 1:54 PM