| cullmann |
| Kate |
In the second column, remove all "file:///" prefixes from the file paths.
Screenshot BEFORE:
(Note, that the screenshot was taken at a time where the file paths in the upper section where not bold (before d6e38c0cbd3d6d7f7658862757b8c33db4322d7a). Now, the items in the first and second column are both bold)
AFTER:
| No Linters Available |
| No Unit Test Coverage |
| Buildable 3877 | |
| Build 3895: arc lint + arc unit |
| kate/katequickopen.cpp | ||
|---|---|---|
| 170 ↗ | (On Diff #43609) | Prefer toDisplayString() for user-visible places which will strip out the password |
I think it is better if D15804 goes in first, e.g. alreadySeenFiles is removed by his change. Maybe @tcanabrava can incorporate the prettyDocumentUrl part if that is still necessary.
This is how it looks like if in the git project are really long filenames:
This is how it looks like after the column sizing proposal:
This, after Ctrl+Alt+O is pressed again after having already entered a filter string:
You have to rebase, and probably fix the conflict because I moved the code
to a real model.
Em qua, 17 de out de 2018 às 13:27, Dominik Haumann <
noreply@phabricator.kde.org> escreveu:
dhaumann added a comment. View Revision
https://phabricator.kde.org/D16204Do you have to rebase your patch now that the other patch is in?
*REPOSITORY*
R40 Kate*REVISION DETAIL*
https://phabricator.kde.org/D16204*To: *gregormi, Kate
*Cc: *broulik, dhaumann, tcanabrava, kwrite-devel, michaelh, ngraham,
demsking, cullmann, sars
| kate/katequickopen.cpp | ||
|---|---|---|
| 166 ↗ | (On Diff #43609) | Note: Is this any different to url.toDisplayString(QUrl::PreferLocalFile) now? |
| kate/katequickopen.cpp | ||
|---|---|---|
| 166 ↗ | (On Diff #43609) | Good idea, I used QUrl::PreferLocalFile in the revised code. |