RFC: Store full URL as URI
AbandonedPublic

Authored by broulik on Oct 9 2018, 8:16 PM.

Details

Reviewers
hein
ivan
apol
Group Reviewers
Plasma
Summary

A recently used file can also be a remote location

BUG: 401579

Test Plan

It took me forever to figure out where this entry actually came from :/
Task Manager uses the URI as QUrl for recent documents and tries to exclude Folders which didn't work as QUrl("/foo/bar") is not localFile` and as such the codepath was never hit.

Not sure what the implications are for this change, it does fix Dolphin showing folders in its task manager context menu, often duplicating the ones from places. Right-click Dolphin, chose e.g. "Downloads", and you end up with a "Downloads" entry without icon in the menu.

Diff Detail

Repository
R161 KActivity Manager Service
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Oct 9 2018, 8:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 9 2018, 8:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Oct 9 2018, 8:16 PM
apol accepted this revision.Oct 10 2018, 2:36 PM
apol added a subscriber: apol.

Makes sense, even the argument is URI

This revision is now accepted and ready to land.Oct 10 2018, 2:36 PM
ivan requested changes to this revision.Oct 10 2018, 3:20 PM

Not sure what the implications are for this change, it does fix Dolphin showing folders in its

This I don't like.

KAMD stores file paths, not URIs for local files in the database.

This needs more investigation of the consequences.

This revision now requires changes to proceed.Oct 10 2018, 3:20 PM

Alright, so we have two bugs then:

  1. Task Manager does QUrl("/foo/bar") which results in an invalid URL. It must use fromLocalFile and/or check for whether it's a /simple/path or sftp://proper/url
  2. EventSpy plugin just does toLocalFile() so recent documents on remote locations aren't stored correctly, despite Url::file() term explicitly mentioning sftp et al
ngraham edited the summary of this revision. (Show Details)Jun 22 2019, 4:18 PM
broulik abandoned this revision.Sep 16 2019, 10:28 AM