Differential D16074

Comment out phonon dependency until sound is reenabled
ClosedPublic
Actions

Authored by arojas on Oct 9 2018, 3:11 PM.

Details

Reviewers
ltoscano
Group Reviewers
KDE Games
Commits
R407:3feffd64a7b5: Comment out phonon dependency
Summary

Sound has been disabled for over 11 years (since 3341cdf094df4598061db922f1a80782218feedc). Comment out the otherwise unnecessary phonon dependency until it is reenabled.

Test Plan

Builds

Diff Detail

Repository
R407 Kolf
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Oct 9 2018, 3:11 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptOct 9 2018, 3:11 PM
arojas requested review of this revision.Oct 9 2018, 3:12 PM
shubham added a reviewer: ltoscano.Oct 9 2018, 3:14 PM
shubham added a subscriber: ltoscano.
shubham removed a subscriber: ltoscano.
ltoscano accepted this revision.Oct 21 2018, 10:55 PM
ltoscano added subscribers: cfeck, aacid.

The change sounds fine, I guess.

Maybe you can push this to Applications/18.08; it's changing the dependencies, but just removing one of them, not adding new ones. When this happens for translations, it does not break the freeze. @aacid, @cfeck, what do you think?

This revision is now accepted and ready to land.Oct 21 2018, 10:55 PM
Closed by commit R407:3feffd64a7b5: Comment out phonon dependency (authored by arojas). · Explain WhyOct 24 2018, 6:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)

Diff 44138

View Options

CMakeLists.txt

Loading...