Don't show an emblem for mounted disks, only unmounted disks
ClosedPublic

Authored by ngraham on Thu, Oct 4, 2:39 AM.

Details

Summary

The HIG now states that should only be used for non-default, uncommon, unusual, or unexpected statuses: https://hig.kde.org/components/assistance/emblem.html

Accordingly, we should only show an emblem when a disk is unmounted, not when it's mounted. Being mounted is the expected status for a disk; being unmounted-but-visible-anyway is what's unusual and deserves an emblem.

As an added bonus, this hugely improves the look of the Places panel by default.

Closes T9740

Test Plan

Dolphin Places panel now:

Devices Notifier:

Diff Detail

Repository
R245 Solid
Branch
no-mounted-emblem (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3470
Build 3488: arc lint + arc unit
ngraham created this revision.Thu, Oct 4, 2:39 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Oct 4, 2:39 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Thu, Oct 4, 2:39 AM
ngraham edited the test plan for this revision. (Show Details)Thu, Oct 4, 2:39 AM
ngraham edited the test plan for this revision. (Show Details)Thu, Oct 4, 2:44 AM
broulik added a subscriber: broulik.Thu, Oct 4, 7:35 AM

I think that's a sensible idea. Can you also evaluate the implications for Device Notifier?

Sure!

External hard drive:

iPhone

(The duplicate entries are caused by https://bugs.kde.org/show_bug.cgi?id=383255

ngraham edited the test plan for this revision. (Show Details)Thu, Oct 4, 6:05 PM
ngraham edited the summary of this revision. (Show Details)Thu, Oct 4, 6:15 PM
ngraham retitled this revision from Don't show a emblem for mounted disks, only unmounted disks to Don't show an emblem for mounted disks, only unmounted disks.Fri, Oct 5, 4:19 AM
abetts accepted this revision.Sat, Oct 6, 1:16 AM
This revision is now accepted and ready to land.Sat, Oct 6, 1:16 AM
ngraham closed this revision.Sat, Oct 6, 2:48 AM