Add new page on Emblems
ClosedPublic

Authored by ngraham on Oct 2 2018, 2:16 PM.

Details

Summary

This fairly basic page describes how to use emblems.

Test Plan

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
emblems (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3492
Build 3510: arc lint + arc unit
ngraham requested review of this revision.Oct 2 2018, 2:16 PM
ngraham created this revision.
ngraham updated this revision to Diff 42724.Oct 2 2018, 2:20 PM

Fix typo

fabianr requested changes to this revision.Oct 2 2018, 2:55 PM

Something very similar to emblems is the use of badges(?), a textual overlay (in the top-right?), that more then 1 new notifications, mails, ... are available. We should either add it to this page, or create a task in the HIG phab board that we need to add information about it.

source/components/assistance/emblem.rst
25

Systray icons put the emblem at the bottom-left corner first at the moment. We should explicit mention that these should or should not follow this rule.

This revision now requires changes to proceed.Oct 2 2018, 2:55 PM
ngraham marked an inline comment as done.Oct 2 2018, 4:27 PM
ngraham updated this revision to Diff 42736.Oct 2 2018, 4:28 PM
  • Add information about notification emblems
  • Mention the system tray
  • Make some general improvements
ngraham edited the test plan for this revision. (Show Details)Oct 2 2018, 4:29 PM

After looking at the volume of icons that would need changing to accommodate a switch to always using the bottom-left corner for the first emblem--both our own and also for 3rd-parties--now I'm thinking that it might make more sense to change the instruction to recommend always using the bottom-right corner, and just change KIconLoader to put the first emblem in the bottom-right corner to match the existing icons. That would be a fairly simple code change that I can do, and it would result in instant consistency for all our icons.

Also, macOS puts their emblems in the bottom right:

Doesn't seem like it's a problem for them.

Thoughts?

ngraham added a reviewer: VDG.Oct 3 2018, 2:24 PM
ngraham updated this revision to Diff 42862.Oct 4 2018, 3:48 PM

Update text and example to reflect new "bottom-right corner first" guideline

ngraham edited the test plan for this revision. (Show Details)Oct 4 2018, 3:49 PM

Here are the phab patches for Solid and KIconThemes that adjust some things to match the new guidelines:

Also, In the process, I've identified a number of other minor issues with our emblems. I have filed Bugzilla tickets for them:

fabianr accepted this revision.Oct 4 2018, 4:16 PM
This revision is now accepted and ready to land.Oct 4 2018, 4:16 PM
ngraham closed this revision.Oct 4 2018, 4:25 PM