Differential D15873

Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.
ClosedPublic
Actions

Authored by madcatx on Oct 1 2018, 9:24 AM.

Details

Reviewers
elvisangelaccio
broulik
Commits
R320:a26de31a5dfb: Distinguish between file and directory delete request in debug output.
Summary

This has proven to be useful while I was tracking down what seems like a glitch in libsmbclient.

Relevant Samba bug report: https://bugzilla.samba.org/show_bug.cgi?id=13637

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
madcatx created this revision.Oct 1 2018, 9:24 AM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptOct 1 2018, 9:24 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
madcatx requested review of this revision.Oct 1 2018, 9:24 AM
broulik accepted this revision.Oct 1 2018, 10:14 AM
This revision is now accepted and ready to land.Oct 1 2018, 10:14 AM
elvisangelaccio accepted this revision.Oct 1 2018, 8:55 PM

@madcatx Time to request commit access? :D

madcatx added a comment.Oct 2 2018, 10:57 AM

@elvisangelaccio: OK, what do I have to do?

Closed by commit R320:a26de31a5dfb: Distinguish between file and directory delete request in debug output. (authored by madcatx). · Explain WhyOct 8 2018, 10:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_dir.cpp (4 lines)

Diff 43120

View Options

smb/kio_smb_dir.cpp

Loading...