hwti (Loïc Yhuel)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2018, 9:12 AM (289 w, 4 d)
Availability
Available

Recent Activity

Sep 23 2019

hwti added a comment to D24150: Fix crash on exit in kio_file.

I (thought I) fixed this crash already in commit 512967f6f4e887d4a5a0 by removing the ::exit() call (which appears in the backtrace of that bug report).

This being said, I'm not objecting to this patch, but I am wondering if you can still experience this crash with a kio that includes my commit above (from Sep 6).

Sep 23 2019, 3:42 AM · Frameworks

Sep 22 2019

hwti updated the diff for D24150: Fix crash on exit in kio_file.
Sep 22 2019, 9:01 PM · Frameworks
hwti added a comment to D24150: Fix crash on exit in kio_file.

why the void? do you get a warning otherwise?

No, but it is used in several places in the repository (and in Qt), so I suppose it might generate one depending on the compiler.

Also a comment in that line quoting the Qt docs "Note that you should not delete codecs yourself: once created they become Qt's responsibility." makes sense IMHO otherwise someone will move it back to the old code to not have a leak

OK, done (but the void should already show that not storing it in a variable, so not deleting it, is deliberate).

Sep 22 2019, 9:00 PM · Frameworks
hwti requested review of D24150: Fix crash on exit in kio_file.
Sep 22 2019, 7:28 PM · Frameworks

Mar 8 2019

hwti added a comment to D13882: Use QTabBar: drop tons of code.

This change breaks the previous behavior when closing a tab : now focus goes to the next tab (or to the last tab when closing the last tab).
Previously, it was going to the previously focused one.
https://bugs.kde.org/show_bug.cgi?id=405213

Mar 8 2019, 1:03 PM · Konsole

Oct 1 2018

hwti requested review of D15872: Fix Oxygen background gradient for QML modules.
Oct 1 2018, 9:21 AM · Frameworks