This e.g. catches the "hang" people did see before the fix in https://phabricator.kde.org/D15773
Its a simple good old "endless loop counter" that aborts after too many transitions.
IMHO more than a few without any progress at the text offset make no sense, therefore the hard limit of 1024 should be reasonable
Details
Details
- Reviewers
dhaumann vkrause nibags - Commits
- R216:899ce3e7bb6e: Endless state transition guard
I tried the examples attached for https://phabricator.kde.org/D15773, with my fix, I get just
Endless state transitions, aborting highlighting of line.
as debug output but no longer any hang.
(but yes, the highlighting of some lines is messed up, which IMHO is ok, much better than a hard hang of the application
Diff Detail
Diff Detail
- Repository
- R216 Syntax Highlighting
- Lint
Lint Skipped - Unit
Unit Tests Skipped