As part of the QTabBar refactoring, honouring of the new tab behaviour
setting was lost. Restore using a simpler implementation that simply
asks QTabWidget for the current index.
BUG: 396701
Details
Details
- Reviewers
hindenburg tcanabrava - Group Reviewers
Konsole - Commits
- R319:f5cc6d6c9061: Restore new tab behavior
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Branch
- restore_new_tab_behavior
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3323 Build 3341: arc lint + arc unit
Comment Actions
I tougth I fixed that a while ago
Em dom, 30 de set de 2018 às 04:34, Nathaniel Graham <
noreply@phabricator.kde.org> escreveu:
ngraham added reviewers: Konsole, hindenburg, tcanabrava. View Revision
https://phabricator.kde.org/D15828
*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D15828*To: *roberts, Konsole, hindenburg, tcanabrava
*Cc: *konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
Comment Actions
I thought this was fixed as well but the 'New tab behavior" setting appears to be ignored.
Comment Actions
@hindenburg, @tcanabrava: I cannot find a pending a review that would re-add this functionality. Should I push this or do you want to deal with it separately?
Comment Actions
Push.
My time is limited unfortunately.
Next week I'll have more time for konsole but work has eating my time.
Em sáb, 6 de out de 2018 às 09:38, Lindsay Roberts <
noreply@phabricator.kde.org> escreveu:
roberts added a comment. View Revision
https://phabricator.kde.org/D15828@hindenburg https://phabricator.kde.org/p/hindenburg/, @tcanabrava
https://phabricator.kde.org/p/tcanabrava/: I cannot find a pending a
review that would re-add this functionality. Should I push this or do you
want to deal with it separately?*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D15828*To: *roberts, Konsole, hindenburg, tcanabrava
*Cc: *konsole-devel, herrold, ngraham, maximilianocuria, hindenburg