[Exe Thumbnailer] Workaround Qt bug in ico detection heuristic
ClosedPublic

Authored by broulik on Sep 28 2018, 3:08 PM.

Details

Summary

Ico files mostly contain PNGs these days which retain their image header when embedded into an ICO file.
As a result the bits per pixel in the ICO header can be missing or incorrect.
Qt still manages to extract the underlying PNG just fine but the canRead gives up prematurely.

Test Plan

I now get thumbnails for "sierra chart" exe file

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 28 2018, 3:08 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptSep 28 2018, 3:08 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Sep 28 2018, 3:08 PM
broulik edited the summary of this revision. (Show Details)
cfeck accepted this revision.Sep 28 2018, 8:43 PM
cfeck added a subscriber: cfeck.
cfeck added inline comments.
thumbnail/icoutils_common.cpp
85 ↗(On Diff #42493)

determine

This revision is now accepted and ready to land.Sep 28 2018, 8:43 PM
This revision was automatically updated to reflect the committed changes.