increase the test coverage by testing more mimetypes, and use some unicode characters
- R286:ae3c38293421: increase test coverage of taglibwriter
taglibwriter test pass
In general this looks good, but I would like two changes:
- Do the conversion to QTest first, and leave out the change for unicode testing (e.g. Title1 -> Title €)
- Add a third column like "stringsuffix", and then add another test (row) for each format. QStringLiteral("Title1") then becomes QStringLiteral("Title1") + stringsuffix
(2.) would go in a dependent review.
Never really though about that, but should be static, yes. None of the writers and extractors I looked at currently do this, so if I find time I will do that for all at once and separately
Can you sort the tests alphabetically? It does not matter much, but IMHO it is nicer to have some rule for ordering, instead of arbitrary order.
Can you also order these alphabetically based on the main mime type (aliases immediate after)?
audio/wav and the next three are not backed by tests AFAICS, can you add these in a separate review, accompanied by tests files?