Differential D15614

remove usage of own TString to QString conversion function
ClosedPublic
Actions

Authored by astippich on Sep 20 2018, 8:32 AM.

Details

Reviewers
bruns
mgallien
svuorela
Commits
R286:4c760d4588f3: remove usage of own TString to QString conversion function
Summary

as pointed out in D13700, the custom function for conversion of taglib string to QString is unsafe and will break if size(wchar) == 4 bytes. Use the function provided by taglib for the conversion to QString.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Sep 20 2018, 8:32 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSep 20 2018, 8:32 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Sep 20 2018, 8:32 AM
astippich added a comment.Sep 20 2018, 8:33 AM

The removal of the convertWCharsToQString function is safe, right? It was never exported

astippich edited the summary of this revision. (Show Details)Sep 20 2018, 8:34 AM
mgallien added a comment.Sep 20 2018, 8:35 AM
In D15614#328722, @astippich wrote:

The removal of the convertWCharsToQString function is safe, right? It was never exported

It is a static function. So it is absolutely safe to remove it.

svuorela accepted this revision.Sep 22 2018, 8:43 PM
This revision is now accepted and ready to land.Sep 22 2018, 8:43 PM
Closed by commit R286:4c760d4588f3: remove usage of own TString to QString conversion function (authored by astippich). · Explain WhySep 23 2018, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractors/taglibextractor.cpp (75 lines)

Diff 42200

View Options

src/extractors/taglibextractor.cpp

Loading...