Differential D15294

Add open on remote device (Desktop)
ClosedPublic
Actions

Authored by nicolasfella on Sep 5 2018, 2:00 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Maniphest Tasks
T8637: [Junior Job] Open on remote device
Commits
R224:ccd476c150e6: Add open on remote device (Desktop)
Summary

Add openFile to Share Plugin and extend handler to open local file urls

Future extension: Modify the desktop file to allow Open with > Open on connected device

Depends on D16605

Test Plan

Apply Android patch. Use kdeconnect-handler file:///somefile. Check phone for reaction

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Sep 5 2018, 2:00 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 5 2018, 2:00 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Sep 5 2018, 2:00 PM
sredman added a subscriber: sredman.Oct 29 2018, 3:14 PM

Could you expand on the test plan for this? As in, what should I see?
Currently (on a build from the master branch) if I do kdeconnect-handler file://<file>, it downloads the file to my phone and the app spawns a notification giving me the option to open it. What does this patch change?

sredman added a comment.Oct 29 2018, 3:32 PM
In D15294#350607, @sredman wrote:

Could you expand on the test plan for this? As in, what should I see?
Currently (on a build from the master branch) if I do kdeconnect-handler file://<file>, it downloads the file to my phone and the app spawns a notification giving me the option to open it. What does this patch change?

Sorry, I am dumb and it didn't connect to me that you had an android-side and desktop-side patch

I am unable to get the devices to connect. The desktop complains with 'kdeconnect.core: Failing due to ("The certificate is self-signed, and untrusted")'

Would it be possible to rebase these on master and re-upload?

nicolasfella updated this revision to Diff 44686.Nov 2 2018, 2:56 AM
  • Default to file sharing again, add option to open
albertvaka accepted this revision.Nov 4 2018, 10:44 AM
This revision is now accepted and ready to land.Nov 4 2018, 10:44 AM
Closed by commit R224:ccd476c150e6: Add open on remote device (Desktop) (authored by nicolasfella). · Explain WhyNov 4 2018, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44864

View Options

plugins/share/shareplugin.h

Loading...
View Options

plugins/share/shareplugin.cpp

Loading...
View Options

urlhandler/kdeconnect-handler.cpp

Loading...