RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()
AbandonedPublic

Authored by broulik on Sep 3 2018, 1:48 PM.

Details

Summary

Avoids creating a QFileInfo which might block stat'ing the file, especially if the information has been filled in by a KIO slave already.

Test Plan
  • Unittest still passes
  • Had an own file that I removed the own permission → became unreadable
  • Had a file from someone else but in the same group as me → was readable

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 3 2018, 1:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 3 2018, 1:48 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Sep 3 2018, 1:48 PM
fvogt requested changes to this revision.Sep 6 2018, 1:29 PM

This will likely not work with ACLs.

This revision now requires changes to proceed.Sep 6 2018, 1:29 PM
broulik abandoned this revision.Sep 10 2018, 8:36 AM

Was an idea :)