Differential D15241

Fix double delete bug in OutputWidget
ClosedPublic
Actions

Authored by vkorneev on Sep 3 2018, 1:13 PM.

Details

Reviewers
kfunk
kossebau
Commits
R32:7b2e5e404254: Fix double delete bug in OutputWidget
Summary

The bug was unfortunately introduced in D14931 by me - two shared pointers
were created from the same raw pointer. Eliminated it by using QSharedPointer
as a return value from view creation helper lambda.

Test Plan

The bug can be triggered only in IOutputView:OneView widget mode, which is (as
far as I can see) currently neither used, nor properly tested. Planning to change
this in following patches.

Diff Detail

Repository
R32 KDevelop
Branch
fix_outputwidget_bug (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2464
Build 2482: arc lint + arc unit
vkorneev created this revision.Sep 3 2018, 1:13 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptSep 3 2018, 1:13 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
vkorneev requested review of this revision.Sep 3 2018, 1:13 PM
anthonyfieroni added a subscriber: anthonyfieroni.Sep 3 2018, 1:25 PM

It looks good to me.

kfunk accepted this revision.Sep 4 2018, 8:27 AM
This revision is now accepted and ready to land.Sep 4 2018, 8:27 AM
Closed by commit R32:7b2e5e404254: Fix double delete bug in OutputWidget (authored by vkorneev, committed by kfunk). · Explain WhySep 4 2018, 8:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40912

View Options

plugins/standardoutputview/outputwidget.cpp

Loading...