Fix double delete bug in OutputWidget
ClosedPublic

Authored by vkorneev on Sep 3 2018, 1:13 PM.

Details

Summary

The bug was unfortunately introduced in D14931 by me - two shared pointers
were created from the same raw pointer. Eliminated it by using QSharedPointer
as a return value from view creation helper lambda.

Test Plan

The bug can be triggered only in IOutputView:OneView widget mode, which is (as
far as I can see) currently neither used, nor properly tested. Planning to change
this in following patches.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkorneev created this revision.Sep 3 2018, 1:13 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptSep 3 2018, 1:13 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
vkorneev requested review of this revision.Sep 3 2018, 1:13 PM

It looks good to me.

kfunk accepted this revision.Sep 4 2018, 8:27 AM
This revision is now accepted and ready to land.Sep 4 2018, 8:27 AM
This revision was automatically updated to reflect the committed changes.