vkorneev (Vyacheslav Korneev)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 5 2018, 4:33 PM (58 w, 15 h)
Availability
Available

Recent Activity

Sep 8 2018

vkorneev added a comment to D15326: Fix segfaults in OutputWidget.

As an author of D14931 I need to apologize for passing this bug and clear a thing about the 2nd case.
In the first version of the aforementioned patch (https://phabricator.kde.org/D14931?id=40016) I used raw pointers instead of QSharedPointer and was calling helper FilteredView::destroy() method in OutputWidget::removeOutput() in order not to store potentially big view and proxy model objects in memory when we don't need them anymore. This shouldn't cause double deletion because children object should remove itself from object hierarchy when being deleted (as far as I understand). Maybe you can use it too if you want.

Sep 8 2018, 4:08 PM · KDevelop

Sep 3 2018

vkorneev added a comment to D14931: Eliminate duplicate QMaps in OutputWidget.

@kossebau , @anthonyfieroni I've sumbitted the patch which should fix the bug: D15241. Hope that it's correct this time.

Sep 3 2018, 1:19 PM · KDevelop
vkorneev requested review of D15241: Fix double delete bug in OutputWidget.
Sep 3 2018, 1:13 PM · KDevelop
vkorneev added a comment to D14931: Eliminate duplicate QMaps in OutputWidget.

@anthonyfieroni, got it, thank you for answer. I'll try to submit the patch with fix today.

Sep 3 2018, 7:21 AM · KDevelop
vkorneev added inline comments to D14931: Eliminate duplicate QMaps in OutputWidget.
Sep 3 2018, 7:19 AM · KDevelop
vkorneev added a comment to D14931: Eliminate duplicate QMaps in OutputWidget.

@anthonyfieroni, @kossebau, yes, that's definitely a bug. I didn't notice it, sorry for that. Should I fix it as a new commit to this patch or create a new patch?

Sep 3 2018, 7:14 AM · KDevelop

Sep 2 2018

vkorneev added a comment to D14931: Eliminate duplicate QMaps in OutputWidget.

Hi @kfunk, you've told that the patch looks good in general except for the redundant m_views.remove(id); call - I've deleted it. So what about the patch now? Should anything else be changed or can it be accepted now?

Sep 2 2018, 9:20 AM · KDevelop

Aug 24 2018

vkorneev added a comment to D14931: Eliminate duplicate QMaps in OutputWidget.

Hi @aaronpuchert, thank you for comment.
I was in doubt between these two variants while writing the code and stopped on current one for two reasons:

  • Looking at QT source code, reset() is ultimately reduced to QSharedPointer copy(t); swap(copy); anyways. And QSharedPointer has move constructor, so it'll work in this case (right?).
  • Current variant better expresses my intentions (that's subjective).

But if you still think that we should use reset() I'd change it in a moment. What do you think?

Aug 24 2018, 1:38 PM · KDevelop

Aug 23 2018

vkorneev added a comment to D14931: Eliminate duplicate QMaps in OutputWidget.

Thanks for your change even if you were not happy about it.

So what do you think? To me that is easier to follow, and gives very few chances for accidental leaks. One should use smart pointers more often these days.

Aug 23 2018, 7:39 PM · KDevelop
vkorneev updated the diff for D14931: Eliminate duplicate QMaps in OutputWidget.

Remove redundant m_views.remove()

Aug 23 2018, 7:29 PM · KDevelop
vkorneev added inline comments to D14931: Eliminate duplicate QMaps in OutputWidget.
Aug 23 2018, 7:27 PM · KDevelop
vkorneev updated the diff for D14931: Eliminate duplicate QMaps in OutputWidget.

Use QSharedPointers instead of raw pointers in FilteredView struct

Aug 23 2018, 5:57 PM · KDevelop
vkorneev added inline comments to D14931: Eliminate duplicate QMaps in OutputWidget.
Aug 23 2018, 5:13 PM · KDevelop

Aug 19 2018

vkorneev added inline comments to D14931: Eliminate duplicate QMaps in OutputWidget.
Aug 19 2018, 9:11 PM · KDevelop
vkorneev updated the diff for D14931: Eliminate duplicate QMaps in OutputWidget.

Multiple improvements corresponding to review comments

Aug 19 2018, 9:07 PM · KDevelop
vkorneev requested review of D14931: Eliminate duplicate QMaps in OutputWidget.
Aug 19 2018, 6:37 PM · KDevelop

Aug 16 2018

vkorneev added a comment to D14750: Fix problems with output filters in StandardOutputView plugin.

Thanks a lot for the patch! Go ahead with refactoring this code in master branch, we'd appreciate it.

Thank you for the review :) I'll proceed to work on this soon.

Aug 16 2018, 9:44 AM · KDevelop
vkorneev added a comment to D14750: Fix problems with output filters in StandardOutputView plugin.

Hi @kfunk. Sorry for being a little obtrusive, but I just wanted to clarify this a little. Should I wait for this ad hoc fix to be reviewed and accepted, or should I go directly to the refactoring and fix the bug on the way?

Aug 16 2018, 7:55 AM · KDevelop

Aug 15 2018

vkorneev added inline comments to D14710: Inject default environment group variables into debug process environment..
Aug 15 2018, 9:26 PM · KDevelop

Aug 14 2018

vkorneev added a reviewer for D14750: Fix problems with output filters in StandardOutputView plugin: brauch.

@brauch , sorry for mentioning you explicitly, just had a feeling that nobody has noticed the request for review :)

Aug 14 2018, 3:06 PM · KDevelop
vkorneev added inline comments to D14710: Inject default environment group variables into debug process environment..
Aug 14 2018, 8:51 AM · KDevelop

Aug 12 2018

vkorneev added a reviewer for D14750: Fix problems with output filters in StandardOutputView plugin: KDevelop.
Aug 12 2018, 4:30 PM · KDevelop

Aug 11 2018

vkorneev added a comment to D14750: Fix problems with output filters in StandardOutputView plugin.

If these changes pass the review, I'd like to also make a little refactoring to this code consisting of using one QMap with structs containing pointers to corresponding view, filter and proxy model instead of 3 QMaps with the same keys in current code. Did I get it right that I should do these changes in separate patch?

Aug 11 2018, 9:19 PM · KDevelop
vkorneev requested review of D14750: Fix problems with output filters in StandardOutputView plugin.
Aug 11 2018, 9:10 PM · KDevelop
vkorneev added a comment to D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.

I've tried to implement the approach discussed above. Here is the video of the results achieved as for now:

Aug 11 2018, 4:01 PM · KDevelop
vkorneev updated the diff for D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.

Implement automatic folder collapse and expand during drag'n'drop

Aug 11 2018, 3:49 PM · KDevelop

Aug 6 2018

vkorneev added a comment to D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.

Hi @kossebau , you're welcome. Thank you for testing my patch :)

Aug 6 2018, 11:56 PM · KDevelop
vkorneev added a comment to D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.

I've removed redundant call to superclass method in ProjectTreeView::timerEvent, yet I don't quite think this could have been the reason of the flickering and, as for now, I can't find any other possible reason of the problem. Dear @croick, could you please tell me what OS do you use, so I can try running in VM and check if the flickering persists?

Aug 6 2018, 1:56 AM · KDevelop
vkorneev updated the diff for D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.

Remove redundant superclass method call

Aug 6 2018, 1:44 AM · KDevelop

Aug 5 2018

vkorneev added a comment to D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.

No, I don't. There where a few little twitches while I was testing it just now, but not the flickering. Here is the video of the test with patch applied.

Aug 5 2018, 10:46 PM · KDevelop
vkorneev updated the summary of D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.
Aug 5 2018, 5:35 PM · KDevelop
vkorneev updated the summary of D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.
Aug 5 2018, 5:33 PM · KDevelop
vkorneev updated the summary of D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.
Aug 5 2018, 5:22 PM · KDevelop
vkorneev requested review of D14633: Fix drag'n'drop behaviour in ProjectTreeView plugin.
Aug 5 2018, 5:20 PM · KDevelop