Differential D15233

Add a tooltip for the appentry in the kicker
Needs ReviewPublic
Actions

Authored by underwit on Sep 3 2018, 9:28 AM.

Details

Reviewers
hein
broulik
davidedmundson
Group Reviewers
Plasma
Summary

Hello!
My improvement shows a tooltip for applications in ther kicker menu.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
underwit created this revision.Sep 3 2018, 9:28 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 3 2018, 9:28 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
underwit requested review of this revision.Sep 3 2018, 9:28 AM
abetts added a subscriber: abetts.Sep 4 2018, 2:17 PM

What would this look like?

underwit updated this revision to Diff 41027.EditedSep 5 2018, 7:56 AM

Screenshot with tooltip

For tooltip i use "comment", "genericname" or "name" from .desktop file

abetts added a comment.Sep 5 2018, 2:17 PM
In D15233#320616, @underwit wrote:

Screenshot with tooltip

For tooltip i use "comment", "genericname" or "name" from .desktop file

Thank you

underwit added a comment.Sep 20 2018, 7:52 AM

Hello! There is a chance that my patch will be apply?

alexeymin added a subscriber: alexeymin.EditedSep 20 2018, 8:22 AM

Why isn't repository for this review set? Which repo should it be?

P.S. Guess it is plasma desktop
P.P.S. I edited and set a repo, but still don't see it assigned in diff detail...

alexeymin added reviewers: hein, broulik, davidedmundson.Sep 20 2018, 8:27 AM
alexeymin set the repository for this revision to R119 Plasma Desktop.
mart added a subscriber: mart.Nov 23 2018, 2:38 PM
In D15233#328690, @alexeymin wrote:

Why isn't repository for this review set? Which repo should it be?

P.S. Guess it is plasma desktop
P.P.S. I edited and set a repo, but still don't see it assigned in diff detail...

yeah, phab kindof requires the arcanist tool to be used to have things correct..

Showing Only Differences

This revision modifies 5 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 41027

View Options

applets/kicker/package/contents/ui/ItemListDelegate.qml

Loading...
View Options

applets/kicker/plugin/appentry.h

Loading...
View Options

applets/kicker/plugin/appentry.cpp

Loading...