implement more basic tags for taglibwriter
ClosedPublic
Actions

Authored by astippich on Sep 2 2018, 2:42 PM.

Details

Reviewers

mgallien
bruns

Commits

R286:0f16dd4d4cbf: implement more basic tags for taglibwriter

Summary

implement all basic tags directly provided by taglib for the taglibwriter

Test Plan

tests pass

Diff Detail

Repository

R286 KFileMetaData

Branch

taglib_write

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 2968
Build 2986: arc lint + arc unit

astippich created this revision.Sep 2 2018, 2:42 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSep 2 2018, 2:42 PM

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Sep 2 2018, 2:42 PM

Harbormaster completed remote builds in B2436: Diff 40858.Sep 2 2018, 2:42 PM

use different test data

Harbormaster completed remote builds in B2439: Diff 40861.Sep 2 2018, 2:58 PM

Can you add some Unicode exercising tests?

autotests/taglibwritertest.cpp
18 ↗	(On Diff #40861)	Side note - bad implementation, see D13700 Also see inverse q2t in taglibwritertest.cpp
src/writers/taglibwriter.cpp
67 ↗	(On Diff #40861)	Tracknumber can be negative AFAIK, "Hidden track"

check for values greater than zero for tracknumber and year

Harbormaster completed remote builds in B2968: Diff 41856.Sep 17 2018, 5:03 PM

In D15220#325580, @bruns wrote:

Can you add some Unicode exercising tests?

I plan to extend the tests in a later patch, if you don't mind, I would prefer to add this there.

autotests/taglibwritertest.cpp
18 ↗	(On Diff #40861)	I have that on my todo list to switch to taglib's builtin functions
src/writers/taglibwriter.cpp
67 ↗	(On Diff #40861)	taglib only allows unsigned int for year and track, so I don't know how that's possible with taglib. I added checks to ensure only values greater zero are written to it.

astippich added a dependent revision: D15704: increase test coverage of taglibwriter.Sep 23 2018, 10:25 AM

astippich added a dependent revision: D15715: remove own implementation of QString to TString conversion for taglibwriter.Sep 23 2018, 7:07 PM

bruns accepted this revision.Sep 27 2018, 10:18 PM

bruns added inline comments.

src/writers/taglibwriter.cpp
67 ↗	(On Diff #40861)	Sorry, erred on the track number, hidden track is "0".

This revision is now accepted and ready to land.Sep 27 2018, 10:18 PM

Closed by commit R286:0f16dd4d4cbf: implement more basic tags for taglibwriter (authored by astippich). · Explain WhySep 28 2018, 7:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/taglibwritertest.cpp (15 lines)
M			src/writers/taglibwriter.cpp (41 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40858	a7dfbbe		Sep 2 2018, 2:42 PM	★	★
Diff 2	40861	a7dfbbe	- use different test data	Sep 2 2018, 2:58 PM	★	★
Diff 3	41856	a7dfbbe	- check for values greater than zero for tracknumber and year	Sep 17 2018, 5:03 PM	★	★
Diff 4	42518	4c760d4	R286:0f16dd4d4cbf4d5c91e92801944d2fbb3b18b2df	Sep 28 2018, 7:56 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
e95803b53d7f	dc48b5a4a560	058caf0ed812	Alexander Stippich	check for values greater than zero for tracknumber and year	Sep 14 2018, 4:34 PM
058caf0ed812	31e40ed57f62	aa0702f113cc	Alexander Stippich	use different test data	Sep 2 2018, 2:58 PM
aa0702f113cc	1e8ddcd1bce4	a7dfbbe23348	Alexander Stippich	implement more basic tags for taglibwriter (Show More…)	Sep 2 2018, 2:40 PM

implement more basic tags for taglibwriterClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 41856

autotests/taglibwritertest.cpp

src/writers/taglibwriter.cpp

implement more basic tags for taglibwriter
ClosedPublic
Actions

Revision Contents
Changeset List