implement more basic tags for taglibwriter
ClosedPublic

Authored by astippich on Sep 2 2018, 2:42 PM.

Details

Summary

implement all basic tags directly provided by taglib for the taglibwriter

Test Plan

tests pass

Diff Detail

Repository
R286 KFileMetaData
Branch
taglib_write
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2968
Build 2986: arc lint + arc unit
astippich created this revision.Sep 2 2018, 2:42 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSep 2 2018, 2:42 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Sep 2 2018, 2:42 PM
astippich updated this revision to Diff 40861.Sep 2 2018, 2:58 PM
  • use different test data
bruns added a comment.Sep 13 2018, 9:27 PM

Can you add some Unicode exercising tests?

autotests/taglibwritertest.cpp
18

Side note - bad implementation, see D13700

Also see inverse q2t in taglibwritertest.cpp

src/writers/taglibwriter.cpp
67

Tracknumber can be negative AFAIK, "Hidden track"

astippich updated this revision to Diff 41856.Sep 17 2018, 5:03 PM
  • check for values greater than zero for tracknumber and year

Can you add some Unicode exercising tests?

I plan to extend the tests in a later patch, if you don't mind, I would prefer to add this there.

autotests/taglibwritertest.cpp
18

I have that on my todo list to switch to taglib's builtin functions

src/writers/taglibwriter.cpp
67

taglib only allows unsigned int for year and track, so I don't know how that's possible with taglib.
I added checks to ensure only values greater zero are written to it.

bruns accepted this revision.Sep 27 2018, 10:18 PM
bruns added inline comments.
src/writers/taglibwriter.cpp
67

Sorry, erred on the track number, hidden track is "0".

This revision is now accepted and ready to land.Sep 27 2018, 10:18 PM
This revision was automatically updated to reflect the committed changes.