Add "KDE Connect Devices" link to remote:/ (Network) folder
AbandonedPublic

Authored by broulik on Aug 27 2018, 1:19 PM.

Details

Reviewers
apol
albertvaka
elvisangelaccio
Group Reviewers
VDG
Test Plan

We have "MTP devices" in there after all

Diff Detail

Repository
R224 KDE Connect
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Aug 27 2018, 1:19 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptAug 27 2018, 1:19 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
broulik requested review of this revision.Aug 27 2018, 1:19 PM

Conceptually, perhaps both this and MTP should go under the top-level Devices category in the Places panel instead? Appearing on-demand, if applicable. The logic would be that users see these features as device access methods, not network protocols

Both KDE Connect devices and MTP devices plugged in via USB show up in Dolphin's Devices places category already, don't they?

Oh, if that's the case, then great! (I don't have an Android phone I can use to test either MTP or KDE Connect).

Why do we need links in remote:/, then?

+1 otherwise

(and imho MTP doesn't really belong to "Network").

kio/CMakeLists.txt
22

DATA_INSTALL_DIR is deprecated, we should use KDE_INSTALL_DATADIR instead.

kio/kdeconnect-network.desktop
4

What's this used for? It's not part of the desktop entry spec, can we drop it?

So, the consensus was to instead drop MTP as neither KDE Connect nor MTP really qualify as "network locations". Moreover, both of them show up in Dolphin's Places panel anyway. Thoughts?

That would make sense to me, yeah.

broulik abandoned this revision.Aug 29 2018, 7:44 AM