[PreviewJob] Send enabled thumbnail plugins to the thumbnail slave
ClosedPublic
Actions

Authored by broulik on Aug 27 2018, 11:35 AM.

Details

Reviewers

Commits

Summary

This way the thumbnailer can use the same enabled plugin configuration as the calling application

CCBUG: 388303

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.Aug 27 2018, 11:35 AM

This revision is now accepted and ready to land.Sep 17 2018, 5:15 PM

This revision was automatically updated to reflect the committed changes.

wbauer added inline comments.

src/widgets/previewjob.cpp
641	That line is commented out. Is this intentional? I don't see how this will change anything... ;-/

src/widgets/previewjob.cpp
641	Aw, crap, that's what happens when you have unstaged changes, I was testing stuff and acceidentally pushed that wrong state, will fix, thanks for noticing. Fixed in 62c57a5f78fc754eb0d1d7c6329f063f55792b19

			Path	Packages
M			src/widgets/previewjob.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40495			Aug 27 2018, 11:32 AM	★	★
Diff 2	41883	78c4f34	R241:b582cd477f657e859818b2deff130ad186a6a704	Sep 18 2018, 8:37 AM	★	★

	Status	Author	Revision
	Closed	broulik	D15097 [Thumbnailer] Use enabled plugins passed in as metadata
	Closed	broulik	D15096 [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave