Diff Detail
- Repository
- R293 Baloo
- Branch
- master-scheduler (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3744 Build 3762: arc lint + arc unit
There is no need for this, just create a new StorageDevices where you need it.
Creating a second StorageDevices instance in a process is quite cheap.
| src/file/fileindexerconfig.cpp | ||
|---|---|---|
| 322 ↗ | (On Diff #40341) | This is bad, you remove the const from the QList<> |
Creating a separate object cluttered the console with duplicated debug output and raised a threading error.
| src/file/fileindexerconfig.cpp | ||
|---|---|---|
| 322 ↗ | (On Diff #40341) | According to https://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops this particular example will detach with or without the const intermediate. |
| src/file/fileindexerconfig.cpp | ||
|---|---|---|
| 322 ↗ | (On Diff #40341) | Citing from above:
|
Then your code is wrong anyway. This is lazy initialization, and if you can not not guarantee it is save to do so, don't do it.
- Re-write the file index scheduler. Combine content indexer suspend logic.
- Update the balooctl tool with the changed suspend/resume behaviour.
- Re-order and use IndexerState to prioritize the indexer thread pool.
- Newline and tab fixes.
- Prevent a scheduler race condition.
- Separate runnableStateChanged into two functors.
- Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
- Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
- Simplify locking the scheduler.
- Adapt index cleaner to scheduler.