Differential D15042

Rework the GridMesh generation
ClosedPublic
Actions

Authored by ervin on Aug 23 2018, 9:47 PM.

Details

Reviewers
laysrodrigues
tcanabrava
patrickelectric
leandrosantiago
rizzitello
Commits
R231:46f0465c0be5: Rework the GridMesh generation
Summary

We now output 40 lines as expected instead of 800 lines overlapping 20
times.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 2177
Build 2195: arc lint + arc unit
ervin requested review of this revision.Aug 23 2018, 9:47 PM
ervin created this revision.
ervin set the repository for this revision to R231 Atelier.Aug 23 2018, 9:55 PM
rizzitello added a comment.Aug 24 2018, 1:20 AM

This patch does not apply cleanly to master. Please check the base

tcanabrava accepted this revision.Aug 24 2018, 9:19 AM

Sith, I where did you had the conflicts?
The code that kevin touched is not changed for quite a while.

I tested the patch series here and things worked as expected so I'm +1.

This revision is now accepted and ready to land.Aug 24 2018, 9:19 AM
laysrodrigues accepted this revision.Aug 25 2018, 12:33 PM
rizzitello accepted this revision.Aug 25 2018, 4:00 PM
Closed by commit R231:46f0465c0be5: Rework the GridMesh generation (authored by ervin). · Explain WhyAug 29 2018, 6:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/3dview/gridmesh.cpp (20 lines)

Diff 40335

View Options

src/widgets/3dview/gridmesh.cpp

Loading...