Home
Phabricator
Search
Log In
Differential
D15037
Cleanup the QML module usage
Closed
Public
Actions
Authored by
ervin
on Aug 23 2018, 9:47 PM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Edit Tasks
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
None
Subscribers
None
Details
Reviewers
laysrodrigues
tcanabrava
patrickelectric
leandrosantiago
rizzitello
Commits
R231:95846b83c9a9: Cleanup the QML module usage
Diff Detail
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 2172
Build 2190: arc lint + arc unit
ervin
requested review of this revision.
Aug 23 2018, 9:47 PM
ervin
created this revision.
Harbormaster
completed remote builds in
B2172: Diff 40330
.
Aug 23 2018, 9:47 PM
ervin
set the repository for this revision to
R231 Atelier
.
Aug 23 2018, 9:55 PM
rizzitello
added a reviewer:
rizzitello
.
Aug 23 2018, 10:07 PM
rizzitello
added a comment.
Aug 24 2018, 1:42 AM
Comment Actions
This does not patch cleanly on master, please check the base
rizzitello
mentioned this in
D15030: Rename AnimatedEntity to SceneEntity
.
Aug 24 2018, 2:03 AM
tcanabrava
accepted this revision.
Aug 24 2018, 9:24 AM
Comment Actions
I like simplifications. :)
This revision is now accepted and ready to land.
Aug 24 2018, 9:24 AM
laysrodrigues
accepted this revision.
Aug 25 2018, 12:26 PM
rizzitello
accepted this revision.
Aug 25 2018, 3:56 PM
Closed by commit
R231:95846b83c9a9: Cleanup the QML module usage
(authored by
ervin
).
·
Explain Why
Aug 29 2018, 6:09 AM
This revision was automatically updated to reflect the committed changes.