Top-align labels in properties dialog
ClosedPublic

Authored by rkflx on Jul 30 2018, 10:19 PM.

Details

Summary

The General tab of KIO's properties dialog shows labels on the
left side, and properties on the right, creating a table-like structure.
Commonly a label should be aligned vertically in such a way it matches
the first line of the properties, to make it clear which properties it
belongs to.

However, this was not yet the case for the Size label.

Test Plan

In Dolphin, select a folder and press Alt+Return. All labels in
PropertiesGeneral should be top-aligned.
Before:


After:

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx created this revision.Jul 30 2018, 10:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 30 2018, 10:19 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
rkflx requested review of this revision.Jul 30 2018, 10:19 PM
cfeck accepted this revision.Jul 31 2018, 1:56 AM
cfeck added a subscriber: cfeck.

Merci :)

Bonus points if you submit another patch that addresses the issue where it starts out with only one text line, then (after computing the size), jumps to a two-line layout.

On remote folders, it looks even worse, because the text line is empty, and so the "Calculate" button looks disconnected from the Size label.

This revision is now accepted and ready to land.Jul 31 2018, 1:56 AM
ngraham accepted this revision.Jul 31 2018, 2:46 AM

Ah, so much better.

Just realized this actually fixes a problem present in KDE 3 already (KDE 2 did not have the second line yet, as far as I could tell in a short but very interesting test).

Bonus points if you submit another patch that addresses the issue where it starts out with only one text line, then (after computing the size), jumps to a two-line layout.

On remote folders, it looks even worse, because the text line is empty, and so the "Calculate" button looks disconnected from the Size label.

True, but that requires a bit more work than a simple drive-by patch ;) For now, I created T9297: Polish file/folder properties dialog for coordination.

This revision was automatically updated to reflect the committed changes.