Reimplement tablet event compression again
ClosedPublic
Actions

Authored by dkazakov on Apr 18 2016, 1:57 PM.

Details

Reviewers

abrahams
timotheegiet
scottpetrovic
rempt

Maniphest Tasks

T738: cage transform is so sluggish it's unusable

Summary

Tablet device gives as quite a lot of events, which are not needed most of the time. Basically, the only tool that needs them is freehand painting tool.

This compression has been removed from the codebase while porting to Qt5. Now it should be recovered again.

How to test the patch:

Try to use Shift+Gesture with your tablet. It should not make your computer almost hang-up when reaching the brush size around 100px
Tablet support should not break in other places: brushes should work fine, including after switching applications, windows or tablet styluses.

The patch is also available in a git branch: kazakov-tablet-compression

Test Plan

Qt version	Windows	Linux	OSX
5.5.x	?	ok (Dmitry)	?
5.6	?	?	?

Diff Detail

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

dkazakov updated this revision to Diff 3401.Apr 18 2016, 1:57 PM

dkazakov retitled this revision from to Reimplement tablet event compression again.

dkazakov updated this object.

dkazakov edited the test plan for this revision. (Show Details)

dkazakov added reviewers: scottpetrovic, abrahams, timotheegiet, rempt.

dkazakov set the repository for this revision to R37 Krita.

dkazakov added a project: Krita: 3.0 bugs sprint.

Restricted Application added a subscriber: woltherav. · View Herald TranscriptApr 18 2016, 1:57 PM

dkazakov edited the test plan for this revision. (Show Details)Apr 18 2016, 1:58 PM

dkazakov updated this object.

Modified a patch to compress mouse events as well!

dkazakov added a task: T738: cage transform is so sluggish it's unusable.Apr 18 2016, 2:45 PM

I tested this patch on my windows machine (with a mouse) and it looks good to me.

Works well with Windows (Qt 5.6) and a tablet. Cage transform is very usable.

I don't think Mac support should block this. And I wouldn't expect Qt 5.6 on Linux to cause any problems since we implement our own input handler anyway.

This revision is now accepted and ready to land.Apr 18 2016, 6:38 PM

Appears not to have problems on a Mac. However, there are some things that I can't test in a meaningful way because assistants are not visible on Macs yet. However, there is no slow down in changing brush size from using the tablet+gesture action or switching applications.

Thank you! Now the patch is in master! :)

Revision Contents
Changeset List

			Path	Packages
M			libs/ui/input/kis_input_manager.h (4 lines)
M			libs/ui/input/kis_input_manager.cpp (65 lines)
M			libs/ui/input/kis_input_manager_p.h (4 lines)
M			libs/ui/input/kis_input_manager_p.cpp (12 lines)