Introduce a test to make sure we're not offering duplicated icons
AbandonedPublic

Authored by apol on Jul 18 2018, 10:34 PM.

Details

Reviewers
andreaska
mart
vkrause
Group Reviewers
Breeze
Frameworks
Summary

At the moment we have them separate in actions, places, applications. This
distinction is nice but it's not being used in practice. This patch introduces
a test that will complain when that happens.

This is actually a problem because it makes the whole icons system more complex
than it should be as we found with itinerary.

CCBUG: 396626

Test Plan

Current output:

)
QDEBUG : DupeTest::test_duplicateNames() duplicated name "user-identity" 3
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("applets/128")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Place) 2 ("places/16", "places/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "audio-volume-medium" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 2 ("status/16", "status/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "face-smile" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Emote) 1 ("emotes/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "audio-volume-muted" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 2 ("status/16", "status/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-75" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "system-users" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/32")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewdvi" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewbib" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewpdf" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "drive-removable-media" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 3 ("devices/16", "devices/22", "devices/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-25" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "amarok_change_language" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "preferences-other" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 2 ("apps/22", "preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-100" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "window-duplicate" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "scanner" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("apps/48")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 1 ("devices/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "document-multiple" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Place) 2 ("places/16", "places/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "applications-internet" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 3 ("apps/16", "apps/22", "preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Category) 1 ("categories/32")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "mail-message" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Place) 2 ("places/16", "places/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "checkmark" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Emblem) 1 ("emblems/8")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "podcast-amarok" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-00" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewhtml" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "audio-volume-high" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 2 ("status/16", "status/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-50" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-disconnected" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "audio-volume-low" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 2 ("status/16", "status/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "system-run" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("apps/48")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "content-loading-symbolic" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/symbolic")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/symbolic")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "rating-unrated" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/symbolic")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Emblem) 1 ("emblems/16")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wired" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "system-lock-screen" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/32")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "help-about" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 4 ("actions/16", "actions/22", "actions/24", "actions/32")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewps" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "user-identity" 3
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("applets/128")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Place) 2 ("places/16", "places/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "audio-volume-medium" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 2 ("status/16", "status/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "face-smile" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Emote) 1 ("emotes/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "audio-volume-muted" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 2 ("status/16", "status/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-75" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "system-users" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/32")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewdvi" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewbib" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewpdf" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "drive-removable-media" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 3 ("devices/16", "devices/22", "devices/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-25" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "amarok_change_language" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "preferences-other" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 2 ("apps/22", "preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-100" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "window-duplicate" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "scanner" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("apps/48")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 1 ("devices/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "document-multiple" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Place) 2 ("places/16", "places/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "applications-internet" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 3 ("apps/16", "apps/22", "preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Category) 1 ("categories/32")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "mail-message" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Place) 2 ("places/16", "places/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "checkmark" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Emblem) 1 ("emblems/8")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "podcast-amarok" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-00" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewhtml" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "audio-volume-high" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 2 ("status/16", "status/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-connected-50" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wireless-disconnected" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "audio-volume-low" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/24")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 2 ("status/16", "status/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "system-run" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("apps/48")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/24")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "content-loading-symbolic" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 1 ("actions/symbolic")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/symbolic")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "rating-unrated" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/symbolic")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Emblem) 1 ("emblems/16")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "network-wired" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(StatusIcon) 1 ("status/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Device) 2 ("devices/16", "devices/22")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "system-lock-screen" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 3 ("actions/16", "actions/22", "actions/32")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "help-about" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Application) 1 ("preferences/32")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 4 ("actions/16", "actions/22", "actions/24", "actions/32")
QDEBUG : DupeTest::test_duplicateNames() duplicated name "viewps" 2
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(Action) 2 ("actions/16", "actions/22")
QDEBUG : DupeTest::test_duplicateNames() in KIconLoaderDummy::Context(MimeType) 4 ("mimetypes/16", "mimetypes/22", "mimetypes/32", "mimetypes/64")

Diff Detail

Repository
R266 Breeze Icons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 988
Build 1001: arc lint + arc unit
apol created this revision.Jul 18 2018, 10:34 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 18 2018, 10:34 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jul 18 2018, 10:34 PM
apol edited the test plan for this revision. (Show Details)Jul 18 2018, 10:35 PM

+1 on the test, can't comment on how to resolve this unfortunately

apol added a subscriber: andreask.Jul 21 2018, 12:45 AM

Can someone from the breeze team confirm the issue? If so I'll help find a solution.

@andreask?

mart added a comment.Jul 23 2018, 3:23 PM

+100 from me as well

ngraham added a subscriber: ngraham.

+1 conceptually.

andreaska accepted this revision.Jul 23 2018, 5:21 PM
This revision is now accepted and ready to land.Jul 23 2018, 5:21 PM
apol added a comment.Jul 23 2018, 11:54 PM

@andreask, thanks for looking into it. Now it's accepted but we'll get a bunch of errors, how do you suggest we resolve it? I'd rather have a plan before landing this.

dfaure added a subscriber: dfaure.Aug 6 2018, 7:36 AM
dfaure added inline comments.
autotests/kiconloaderdummy.h
1

copyright header missing

9

This includes all of QtTest *plus* all of QtCore. Prefer <QTest>

@apol we have a duplicate test in breeze-icons now; is this still relevant?

apol abandoned this revision.Dec 6 2019, 1:00 AM

Doesn't seem relevant anymore