Differential D1418

Expose client shade state to kwayland's interface.
ClosedPublic
Actions

Authored by hein on Apr 15 2016, 11:43 AM.

Tags

Subscribers

sebas, plasma-devel

Details

Reviewers

Commits

R108:ef6a2cfa649c: Expose client shade state to kwayland's interface.

Summary

Makes use of new API in kwayland to expose shade state.

Depends on D1417.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein updated this revision to Diff 3354.Apr 15 2016, 11:43 AM

hein retitled this revision from to Expose client shade state to kwayland's interface..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added a reviewer: graesslin.

hein added a dependency: D1417: Add window shade support to protocol, interfaces and test..

hein added a subscriber: plasma-devel.

Restricted Application added a project: Plasma. · View Herald TranscriptApr 15 2016, 11:43 AM

sebas added a subscriber: sebas.Apr 15 2016, 12:34 PM

sebas added inline comments.

abstract_client.cpp
651	Shadable vs. Shadeable (one with "e", one without)
652	setShaded vs. isShade (missing "d"?)

graesslin added inline comments.Apr 15 2016, 1:26 PM

abstract_client.cpp
652	for historic reasons in KWin it's called isShade and not isShaded

hein added inline comments.Apr 15 2016, 1:39 PM

abstract_client.cpp
651	I chose to go without the 'e' because kwayland has existing API in this style, e.g. IsMinimizable and IsMaximizable. Maybe there's some sort of orthography rule deciding when it's dropped and when it's kept ...

hein added inline comments.Apr 15 2016, 1:46 PM

abstract_client.cpp
651	Some info: https://howtospell.co.uk/droptheerule.php http://english.stackexchange.com/questions/55193/when-to-drop-the-e-when-ending-in-able It's a wash. kwin uses e here. kwayland actually has both e and no-e examples. I can change it, but note the change actually needs to happen in the dependent revision since it's a kwayland method.

Switch to naming suggested by native speakers.

graesslin accepted this revision.Apr 19 2016, 9:55 AM

graesslin edited edge metadata.

This revision is now accepted and ready to land.Apr 19 2016, 9:55 AM

Closed by commit R108:ef6a2cfa649c: Expose client shade state to kwayland's interface. (authored by hein). · Explain WhyApr 19 2016, 9:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.cpp (8 lines)

Diff 3411

abstract_client.cpp

Loading...