This adds support for 'shadable' and 'shaded' states to the protocol and
to the client and server classes, as well as the window model.
Details
Details
- Reviewers
graesslin - Commits
- R127:e1eb5dcf2dbf: Add API version info; fix references to protocol version.
R127:46047809c8a8: Fix comment, make explicit which object the slot is called on.
R127:44705e5a7634: Add window shade support to protocol, interfaces and test.
R127:455cfcad79df: Switch to naming suggested by native speakers.
The PlasmaWindowModel test has been extended to test the new states.
Diff Detail
Diff Detail
- Repository
- R127 KWayland
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
In Registry you need to adjust:
{Registry::Interface::PlasmaWindowManagement, {
2,
QByteArrayLiteral("org_kde_plasma_window_management"),
&org_kde_plasma_window_management_interface,
&Registry::plasmaWindowManagementAnnounced,
&Registry::plasmaWindowManagementRemoved
}},| src/client/plasmawindowmanagement.h | ||
|---|---|---|
| 291–292 | please add: @since 5.7 | |
| src/client/plasmawindowmodel.h | ||
| 77–80 | please add: @since 5.7 | |
| src/server/plasmawindowmanagement_interface.cpp | ||
| 108 | 3 | |
| src/server/plasmawindowmanagement_interface.h | ||
| 122–123 | Please add @since 5.7 | |
Comment Actions
- Add API version info; fix references to protocol version.
- Fix comment, make explicit which object the slot is called on.
| src/client/protocols/plasma-window-management.xml | ||
|---|---|---|
| 44 | I think we need to ask native speakers whether this is shadable or shadeable. I asked Riddell: [10:50] <mgraesslin> Riddell: I need help with English: what's correct to you? "shadeable" or "shadable"? I would want to ask more native speakers for it. Let's make it proper English ;-) | |
Comment Actions
- Add API version info; fix references to protocol version.
- Fix comment, make explicit which object the slot is called on.
- Add states and request methods for move and resize.