Differential D1434

Hook up movable and resizable states.
ClosedPublic
Actions

Authored by hein on Apr 17 2016, 2:45 PM.

Tags

Subscribers

Details

Reviewers

Commits

R108:7804a352a896: Hook up movable and resizable states.

Summary

Sets movable and resizable states on the Wayland window.

kwin doesn't have state change signals for this, so it's a one-time thing.

Depends on D1432.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein updated this revision to Diff 3387.Apr 17 2016, 2:45 PM

hein retitled this revision from to Hook up movable and resizable states..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added a reviewer: graesslin.

hein added a dependency: D1432: Add states and request methods for move and resize..

hein added a subscriber: plasma-devel.

Restricted Application added a project: Plasma. · View Herald TranscriptApr 17 2016, 2:45 PM

Adapt to changed kwayland API.

graesslin added inline comments.Apr 19 2016, 11:55 AM

abstract_client.cpp
696–705	Cursor::pos() seems wrong to me. If it's triggered by e.g. the task manager the cursor will be on the task item and thus the first movement will make the window jump. My suggestions would be adding a: Cursor::setPos(geometry()->center()); It might also need a test case like the one for netMoveRequest.

Duplicate cursor warping a la useractions.

graesslin accepted this revision.Apr 19 2016, 12:06 PM

graesslin edited edge metadata.

This revision is now accepted and ready to land.Apr 19 2016, 12:06 PM

Closed by commit R108:7804a352a896: Hook up movable and resizable states. (authored by hein). · Explain WhyApr 19 2016, 12:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.cpp (14 lines)

Diff 3421

abstract_client.cpp

Loading...