Add window shade support to protocol, interfaces and test.
ClosedPublic

Authored by hein on Apr 15 2016, 11:39 AM.

Details

Summary

This adds support for 'shadable' and 'shaded' states to the protocol and
to the client and server classes, as well as the window model.

Test Plan

The PlasmaWindowModel test has been extended to test the new states.

Diff Detail

Repository
R127 KWayland
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
hein updated this revision to Diff 3353.Apr 15 2016, 11:39 AM
hein retitled this revision from to Add window shade support to protocol, interfaces and test..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added a reviewer: graesslin.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 15 2016, 11:39 AM
graesslin requested changes to this revision.Apr 15 2016, 12:02 PM
graesslin edited edge metadata.

In Registry you need to adjust:

    {Registry::Interface::PlasmaWindowManagement, {
    2,
    QByteArrayLiteral("org_kde_plasma_window_management"),
    &org_kde_plasma_window_management_interface,
    &Registry::plasmaWindowManagementAnnounced,
    &Registry::plasmaWindowManagementRemoved
}},
src/client/plasmawindowmanagement.h
291–292

please add:

@since 5.7
src/client/plasmawindowmodel.h
77–86

please add:

@since 5.7
src/server/plasmawindowmanagement_interface.cpp
108

3

src/server/plasmawindowmanagement_interface.h
122–123

Please add

@since 5.7
This revision now requires changes to proceed.Apr 15 2016, 12:02 PM
hein updated this revision to Diff 3355.Apr 15 2016, 12:11 PM
hein edited edge metadata.
  • Add API version info; fix references to protocol version.
sebas added a subscriber: sebas.Apr 15 2016, 12:40 PM
sebas added inline comments.
src/client/plasmawindowmanagement.h
261 ↗(On Diff #3355)

maximized? Should be shaded, no?

src/client/plasmawindowmodel.cpp
135 ↗(On Diff #3355)

If it's operating on this, the slot should be run in this' context (we had crashers due to "this" missing here)

139 ↗(On Diff #3355)

same as above

hein updated this revision to Diff 3379.Apr 17 2016, 6:36 AM
hein edited edge metadata.
  • Add API version info; fix references to protocol version.
  • Fix comment, make explicit which object the slot is called on.
graesslin added inline comments.Apr 18 2016, 8:56 AM
src/client/protocols/plasma-window-management.xml
44

I think we need to ask native speakers whether this is shadable or shadeable. I asked Riddell:

[10:50] <mgraesslin> Riddell: I need help with English: what's correct to you? "shadeable" or "shadable"?
[10:51] <Riddell> mgraesslin: I'd go for shadeable
[10:51] <Riddell> shadable I'd want to pronounce shah-d-able

I would want to ask more native speakers for it. Let's make it proper English ;-)

hein updated this revision to Diff 3409.Apr 19 2016, 9:41 AM
  • Add API version info; fix references to protocol version.
  • Fix comment, make explicit which object the slot is called on.
  • Add states and request methods for move and resize.
graesslin accepted this revision.Apr 19 2016, 9:49 AM
graesslin edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 9:49 AM
This revision was automatically updated to reflect the committed changes.