Fix blur behind folderview context menus

Authored by davidedmundson on Jul 16 2018, 10:52 PM.



Breeze has

if (!(widget->testAttribute(Qt::WA_WState_Created) ||

KWindowSystem::blur(widget->winId(), ...)

which makes sense as the style should not be creating surfaces in polish
and I don't want to remove it.

This is problematic with QMenu::polish which has a subtle behavioural
change compared to QMenu::exec in that it calls ensurePolish before
creating the surface.

Plasma::ContainmentInterface accidentally has this workaround already
for parent window setting.

BUG: 395262

Test Plan

Right clicked on desktop icon
Looked amazing

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 16 2018, 10:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jul 16 2018, 10:52 PM
hein accepted this revision.Jul 17 2018, 5:07 AM
hein added a subscriber: hein.

We have blurred context menus now? Wtf.

But ok.

This revision is now accepted and ready to land.Jul 17 2018, 5:07 AM
This revision was automatically updated to reflect the committed changes.
In D14174#293468, @hein wrote:

We have blurred context menus now? Wtf.

But ok.

It's an optional setting in the Breeze theme. Not really my thing, but I have to admit that user feedback has been overwhelmingly positive so far!