Differential D14161

[KStyle] Use dialog-question for question icon
ClosedPublic
Actions

Authored by broulik on Jul 16 2018, 3:46 PM.

Details

Reviewers
dfaure
ngraham
rkflx
Commits
R252:baf011a72ffc: [KStyle] Use dialog-question for question icon
Summary

This was changed in KMessageBox in 9b05a12a43dbe2b31a4655052f20de0832ac7a61 but never "upstreamed" to KStyle which wasn't an issue until D14160

dialog-information is kept as a fallback since e.g. Oxygen doesn't have dialog-question since using that icon is a pretty new addition

Test Plan

kdialog --yesno "test" shows question mark icon again in Breeze. shows information icon still with Oxygen.

Diff Detail

Repository
R252 Framework Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 16 2018, 3:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 16 2018, 3:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jul 16 2018, 3:46 PM
rkflx accepted this revision.Jul 17 2018, 11:52 PM

Thanks for noticing, LGTM and restores the proper icon indeed.

This was changed in KMessageBox in 9b05a12a43dbe2b31a4655052f20de0832ac7a61 but never "upstreamed" to KStyle

Sorry, did not know about this, and neither did the reviewer notice.

Should I submit Diffs (or commit directly?) where the wrong icon is still in use, e.g. here, here, here and/or here?

This revision is now accepted and ready to land.Jul 17 2018, 11:52 PM
Closed by commit R252:baf011a72ffc: [KStyle] Use dialog-question for question icon (authored by broulik). · Explain WhyAug 8 2018, 7:31 AM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Aug 8 2018, 1:57 PM
In D14161#294031, @rkflx wrote:

Thanks for noticing, LGTM and restores the proper icon indeed.

This was changed in KMessageBox in 9b05a12a43dbe2b31a4655052f20de0832ac7a61 but never "upstreamed" to KStyle

Sorry, did not know about this, and neither did the reviewer notice.

Should I submit Diffs (or commit directly?) where the wrong icon is still in use, e.g. here, here, here and/or here?

Yes please. Committing directly should be fine.

Revision Contents
Changeset List

PathPackages
Msrc/kstyle/kstyle.cpp (3 lines)

Diff 39287

View Options

src/kstyle/kstyle.cpp

Loading...