This patch tweaks the text and design for the playlist when it's empty so it's a bit clearer.
Details
- Reviewers
astippich - Group Reviewers
Elisa - Commits
- R255:d38ca6962be7: Tweak inital state for playlist
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Thanks for the ping! This was mostly done but I had forgotten about it
- Change text
- Use layout properties instead of anchors
- Center the empty list text (a little hackish)
src/qml/MediaPlayListView.qml | ||
---|---|---|
170 | Unfortunately, now this creates a binding loop and gives a warning, because the parent height also depends on the margin. Item { Layout.fillHeight: true } |
If no-one objects, I will accept and land this diff soon, and fix the error afterwards
Hi guys, sorry I've been dropping the ball on this one. I had reverted this some weeks ago but couldn't find another way to center it. And then I didn't have time to get back on it.
+1 for landing it now
src/qml/MediaPlayListView.qml | ||
---|---|---|
170 | True, but I can't think of any other way to center this item vertically otherwise. If I use the previous property it ends up too low (because it's taking into account the height of the entire sidebar). |
I think it is still an improvement even without centering it, so I will remove the binding loop to the solution you provided before.