Differential D14052

Add bluetooth plugin
ClosedPublic
Actions

Authored by nicolasfella on Jul 11 2018, 5:13 PM.

Details

Reviewers
apol
ngraham
Commits
R495:0c9bf25e18a8: Add bluetooth plugin
Summary

Replace Bluedevil's FileItemActionPlugin

Test Plan

Share > Send via Bluetooth > Pick Device. Check for received file on other device.

Diff Detail

Repository
R495 Purpose Library
Branch
bluetooth
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 754
Build 767: arc lint + arc unit
nicolasfella created this revision.Jul 11 2018, 5:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 11 2018, 5:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 11 2018, 5:13 PM
nicolasfella updated this revision to Diff 37583.Jul 11 2018, 5:15 PM
  • Revert unintended change
ngraham accepted this revision.Jul 13 2018, 1:01 PM

Looks great and works great!

This revision is now accepted and ready to land.Jul 13 2018, 1:01 PM
nicolasfella added a comment.Jul 16 2018, 1:30 PM

@apol I would like your opinion before merging

apol accepted this revision.Jul 16 2018, 4:02 PM

LGTM overall.

src/plugins/bluetooth/CMakeLists.txt
1

Maybe should have find_qmlmodule(org.kde.bluezqt 1.0)?

nicolasfella added inline comments.Jul 16 2018, 9:49 PM
src/plugins/bluetooth/CMakeLists.txt
1

Makes sense.

When I include it cmake tells me it's not found, although /usr/lib/qt/qml/org/kde/bluezqt exists. Am I missing something?

apol added a comment.Jul 17 2018, 4:05 PM

Yes, I can reproduce too. qmlplugindump-qt5 org.kde.bluezqt 1.0 returns 2 for some reason. Will have to investigate.

Land this for now if you want.

Closed by commit R495:0c9bf25e18a8: Add bluetooth plugin (authored by nicolasfella). · Explain WhyJul 17 2018, 4:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37583

View Options

src/plugins/CMakeLists.txt

Loading...
View Options

src/plugins/bluetooth/CMakeLists.txt

Loading...
View Options

src/plugins/bluetooth/Messages.sh

Loading...
View Options

src/plugins/bluetooth/bluetoothplugin.cpp

Loading...
View Options

src/plugins/bluetooth/bluetoothplugin.json

Loading...
View Options

src/plugins/bluetooth/bluetoothplugin_config.qml

Loading...