Differential D13941

Honor BUILD_TESTING
ClosedPublic
Actions

Authored by arojas on Jul 8 2018, 9:50 AM.

Details

Reviewers
dfaure
Commits
R244:bb56c91ede0f: Honor BUILD_TESTING
Summary

Only build tests if BUILD_TESTING is on

Test Plan

Builds

Diff Detail

Repository
R244 KCoreAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Jul 8 2018, 9:50 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 8 2018, 9:50 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
arojas requested review of this revision.Jul 8 2018, 9:50 AM
elvisangelaccio added a subscriber: elvisangelaccio.Jul 8 2018, 1:15 PM

Isn't BUILD_TESTING already honored by ecm_add_tests ?

arojas added a comment.Jul 8 2018, 1:25 PM

There's more stuff being built inside tests and autotests besides ecm_add_tests

dfaure accepted this revision.Jul 8 2018, 10:34 PM
This revision is now accepted and ready to land.Jul 8 2018, 10:34 PM
Closed by commit R244:bb56c91ede0f: Honor BUILD_TESTING (authored by arojas). · Explain WhyJul 8 2018, 10:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)

Diff 37393

View Options

CMakeLists.txt

Loading...