aleksejshilin (Алексей Шилин)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 20 2017, 9:45 PM (96 w, 4 h)
Availability
Available

Recent Activity

Jul 9 2018

aleksejshilin committed R241:7d15dad5e427: Don't show confirmation dialog for Trash action by default (authored by aleksejshilin).
Don't show confirmation dialog for Trash action by default
Jul 9 2018, 10:36 AM
aleksejshilin closed D13921: Don't show confirmation dialog for Trash action by default.
Jul 9 2018, 10:36 AM · Frameworks
aleksejshilin updated the summary of D13921: Don't show confirmation dialog for Trash action by default.
Jul 9 2018, 10:34 AM · Frameworks

Jul 8 2018

aleksejshilin added a comment to D13921: Don't show confirmation dialog for Trash action by default.

There's a problem with the git setup on the computer you used to make this commit; the name field appears to be empty, so I get an error when I try to apply the patch

Jul 8 2018, 8:17 AM · Frameworks

Jul 6 2018

aleksejshilin committed R120:eaa093443a7c: [User Switcher] Swap Cancel and Switch buttons (authored by aleksejshilin).
[User Switcher] Swap Cancel and Switch buttons
Jul 6 2018, 1:11 PM
aleksejshilin closed D13923: [User Switcher] Swap Cancel and Switch buttons.
Jul 6 2018, 1:11 PM · Plasma
aleksejshilin requested review of D13923: [User Switcher] Swap Cancel and Switch buttons.
Jul 6 2018, 12:42 PM · Plasma
aleksejshilin requested review of D13921: Don't show confirmation dialog for Trash action by default.
Jul 6 2018, 11:07 AM · Frameworks

May 14 2018

aleksejshilin committed R119:ada8fca90381: Remove D10890 workaround (authored by aleksejshilin).
Remove D10890 workaround
May 14 2018, 3:21 PM
aleksejshilin closed D12701: Remove D10890 workaround.
May 14 2018, 3:21 PM · Plasma

May 4 2018

aleksejshilin requested review of D12701: Remove D10890 workaround.
May 4 2018, 8:27 PM · Plasma

Apr 28 2018

aleksejshilin committed R241:47340d6a554c: concatPaths: process empty path1 correctly (authored by aleksejshilin).
concatPaths: process empty path1 correctly
Apr 28 2018, 5:41 PM
aleksejshilin closed D12490: concatPaths: process empty path1 correctly.
Apr 28 2018, 5:41 PM · Frameworks

Apr 24 2018

aleksejshilin added a comment to D12490: concatPaths: process empty path1 correctly.

path1 *should* never be empty

Apr 24 2018, 12:40 PM · Frameworks
aleksejshilin added reviewers for D12490: concatPaths: process empty path1 correctly: anthonyfieroni, dfaure.
Apr 24 2018, 11:27 AM · Frameworks
aleksejshilin requested review of D12490: concatPaths: process empty path1 correctly.

Here is an example of KUrlCompletion breakage.
Before, it returned invalid absolute paths like /Desktop etc.:


After:

Apr 24 2018, 9:32 AM · Frameworks
aleksejshilin planned changes to D12490: concatPaths: process empty path1 correctly.
Apr 24 2018, 9:19 AM · Frameworks
aleksejshilin requested review of D12490: concatPaths: process empty path1 correctly.
Apr 24 2018, 9:19 AM · Frameworks

Apr 22 2018

aleksejshilin committed R108:5a14b6a6a2a9: Improve tooltips behavior (authored by aleksejshilin).
Improve tooltips behavior
Apr 22 2018, 8:45 PM
aleksejshilin closed D12404: Improve tooltips behavior.
Apr 22 2018, 8:45 PM · KWin
aleksejshilin updated the summary of D12404: Improve tooltips behavior.
Apr 22 2018, 8:43 PM · KWin
aleksejshilin updated the diff for D12404: Improve tooltips behavior.
  • Use QDeadlineTimer
Apr 22 2018, 5:44 PM · KWin
aleksejshilin added inline comments to D12404: Improve tooltips behavior.
Apr 22 2018, 5:43 PM · KWin

Apr 21 2018

aleksejshilin requested review of D12404: Improve tooltips behavior.
Apr 21 2018, 1:44 PM · KWin

Apr 2 2018

aleksejshilin committed R40:c3ca6641b4f8: Merge branch 'Applications/18.04' (authored by aleksejshilin).
Merge branch 'Applications/18.04'
Apr 2 2018, 4:24 PM
aleksejshilin committed R40:0a73e00e6dd7: Don't restart the blocking process on session restore (authored by aleksejshilin).
Don't restart the blocking process on session restore
Apr 2 2018, 4:10 PM
aleksejshilin closed D11818: Don't restart the blocking process on session restore.
Apr 2 2018, 4:10 PM · Kate
aleksejshilin added a comment to D11818: Don't restart the blocking process on session restore.

Am I expected to cherry-pick this commit to the Applications/18.04 branch after pushing it to master?

Apr 2 2018, 9:55 AM · Kate
aleksejshilin updated the summary of D11818: Don't restart the blocking process on session restore.
Apr 2 2018, 9:53 AM · Kate

Mar 31 2018

aleksejshilin added a comment to D11818: Don't restart the blocking process on session restore.

Would it also be possible to call setRestartHint() directly, or why is the connect required?

Mar 31 2018, 2:48 PM · Kate

Mar 30 2018

aleksejshilin requested review of D11818: Don't restart the blocking process on session restore.
Mar 30 2018, 8:00 PM · Kate

Mar 15 2018

aleksejshilin added a comment to D11331: add gaming_input devices and others to Battery.

Okay :) But what's about the other entries, like UP_DEVICE_KIND_TABLET, UP_DEVICE_KIND_MEDIA_PLAYER?
Is there a reason why they are excluded?

Mar 15 2018, 6:17 PM · Frameworks

Mar 14 2018

aleksejshilin added inline comments to D11331: add gaming_input devices and others to Battery.
Mar 14 2018, 3:04 PM · Frameworks

Mar 10 2018

aleksejshilin committed R120:8527b640a6f7: Merge branch 'Plasma/5.12' (authored by aleksejshilin).
Merge branch 'Plasma/5.12'
Mar 10 2018, 1:25 PM
aleksejshilin committed R120:bb5645d8c6e7: Use separate config group for each wallpaper plugin (authored by aleksejshilin).
Use separate config group for each wallpaper plugin
Mar 10 2018, 1:24 PM
aleksejshilin closed D11195: Use separate config group for each wallpaper plugin.
Mar 10 2018, 1:23 PM · Plasma
aleksejshilin committed R119:26f073c0ebc4: Merge branch 'Plasma/5.12' (authored by aleksejshilin).
Merge branch 'Plasma/5.12'
Mar 10 2018, 1:21 PM
aleksejshilin committed R119:b0304a2ef312: Load correct wallpaper plugin configuration in the dialog (authored by aleksejshilin).
Load correct wallpaper plugin configuration in the dialog
Mar 10 2018, 1:19 PM
aleksejshilin closed D11194: Load correct wallpaper plugin configuration in the dialog.
Mar 10 2018, 1:19 PM · Plasma
aleksejshilin added a comment to D11195: Use separate config group for each wallpaper plugin.

typically we'd do cfg = cfg.group("") which IMHO is easier to read

Mar 10 2018, 12:47 PM · Plasma
aleksejshilin added a comment to D11195: Use separate config group for each wallpaper plugin.

Fix setting cfg twice

Mar 10 2018, 11:32 AM · Plasma
aleksejshilin added a comment to D11195: Use separate config group for each wallpaper plugin.

One could argue keeping the colour persist across wallpapers is a feature, what problems does it cause?

Mar 10 2018, 11:12 AM · Plasma
aleksejshilin added a comment to D11194: Load correct wallpaper plugin configuration in the dialog.

I think there's a bug report about this somewhere if you want to find it.

Mar 10 2018, 8:49 AM · Plasma

Mar 9 2018

aleksejshilin requested review of D11195: Use separate config group for each wallpaper plugin.
Mar 9 2018, 10:04 PM · Plasma
aleksejshilin requested review of D11194: Load correct wallpaper plugin configuration in the dialog.
Mar 9 2018, 10:03 PM · Plasma

Mar 8 2018

aleksejshilin committed R119:fba2c07b3b11: Merge branch 'Plasma/5.12' (authored by aleksejshilin).
Merge branch 'Plasma/5.12'
Mar 8 2018, 11:46 AM
aleksejshilin committed R119:ca96f850efbf: Don't skip certain recent documents in kicker and taskmanager (authored by aleksejshilin).
Don't skip certain recent documents in kicker and taskmanager
Mar 8 2018, 11:42 AM
aleksejshilin closed D10890: Don't skip certain recent documents in kicker and taskmanager.
Mar 8 2018, 11:42 AM · Plasma

Mar 5 2018

aleksejshilin updated the test plan for D10890: Don't skip certain recent documents in kicker and taskmanager.
Mar 5 2018, 9:45 AM · Plasma
aleksejshilin updated the diff for D10890: Don't skip certain recent documents in kicker and taskmanager.
  • Use QString::mid()
Mar 5 2018, 9:39 AM · Plasma

Mar 4 2018

aleksejshilin updated the diff for D10890: Don't skip certain recent documents in kicker and taskmanager.
  • Make sure to forget all documents, too
Mar 4 2018, 9:11 PM · Plasma
aleksejshilin retitled D10890: Don't skip certain recent documents in kicker and taskmanager from Prepare for KIO KRecentDocument fix (D10863) to Don't skip certain recent documents in kicker and taskmanager.
Mar 4 2018, 7:55 PM · Plasma
aleksejshilin updated the diff for D10890: Don't skip certain recent documents in kicker and taskmanager.
  • Clean up and better comment the code
Mar 4 2018, 7:55 PM · Plasma
aleksejshilin committed R241:37868c2c57f7: Fix protocol selection in KUrlNavigator (authored by aleksejshilin).
Fix protocol selection in KUrlNavigator
Mar 4 2018, 10:41 AM
aleksejshilin closed D10993: Fix protocol selection in KUrlNavigator.
Mar 4 2018, 10:41 AM · Frameworks
aleksejshilin added inline comments to D10993: Fix protocol selection in KUrlNavigator.
Mar 4 2018, 10:18 AM · Frameworks
aleksejshilin updated the diff for D10993: Fix protocol selection in KUrlNavigator.
  • Move setting authority to the else branch
Mar 4 2018, 10:17 AM · Frameworks

Mar 3 2018

aleksejshilin updated the diff for D10993: Fix protocol selection in KUrlNavigator.
  • Add comment explaining the empty authority
Mar 3 2018, 9:08 PM · Frameworks
aleksejshilin added inline comments to D10993: Fix protocol selection in KUrlNavigator.
Mar 3 2018, 8:34 PM · Frameworks
aleksejshilin requested review of D10993: Fix protocol selection in KUrlNavigator.
Mar 3 2018, 3:39 PM · Frameworks

Mar 2 2018

aleksejshilin updated the diff for D10890: Don't skip certain recent documents in kicker and taskmanager.

Diff against Plasma/5.12

Mar 2 2018, 12:16 PM · Plasma
aleksejshilin updated the diff for D10890: Don't skip certain recent documents in kicker and taskmanager.

Rebase onto Plasma/5.12

Mar 2 2018, 11:53 AM · Plasma
aleksejshilin added a comment to D10890: Don't skip certain recent documents in kicker and taskmanager.

So why you called hack, why no just add conditional compilation against 5.44

Mar 2 2018, 11:50 AM · Plasma

Mar 1 2018

aleksejshilin committed R119:88d866c07951: [kicker] Never execute recent documents (authored by aleksejshilin).
[kicker] Never execute recent documents
Mar 1 2018, 4:19 PM
aleksejshilin closed D10835: [kicker] Never execute recent documents.
Mar 1 2018, 4:18 PM · Plasma
aleksejshilin added a comment to D10835: [kicker] Never execute recent documents.

If there are no more concerns, could anyone actually accept the revision, please? :) Thanks in advance!

Mar 1 2018, 3:30 PM · Plasma

Feb 27 2018

aleksejshilin requested review of D10890: Don't skip certain recent documents in kicker and taskmanager.
Feb 27 2018, 3:21 PM · Plasma
aleksejshilin updated the diff for D10835: [kicker] Never execute recent documents.
  • Use proper coding style
Feb 27 2018, 8:28 AM · Plasma
aleksejshilin added a comment to D10835: [kicker] Never execute recent documents.
In D10835#214865, @hein wrote:

Do you have a contributor account to commit this or should we do it on your behalf?

Feb 27 2018, 7:28 AM · Plasma
aleksejshilin added a comment to D10835: [kicker] Never execute recent documents.

So why not do the same here instead of offering "Open With"?

Feb 27 2018, 6:53 AM · Plasma

Feb 26 2018

aleksejshilin added a comment to D10835: [kicker] Never execute recent documents.

Can you check whether this affects Task manager also?

Feb 26 2018, 7:06 AM · Plasma

Feb 25 2018

aleksejshilin requested review of D10835: [kicker] Never execute recent documents.
Feb 25 2018, 2:46 PM · Plasma

Feb 23 2018

aleksejshilin added a comment to D8958: Fix unintentional breadcrumb menu item activation.

@aleksejshilin doesn't have commit access

Feb 23 2018, 5:55 PM · Frameworks
aleksejshilin committed R241:4a6a3b81bedc: Fix unintentional breadcrumb menu item activation (authored by aleksejshilin).
Fix unintentional breadcrumb menu item activation
Feb 23 2018, 5:43 PM
aleksejshilin closed D8958: Fix unintentional breadcrumb menu item activation.
Feb 23 2018, 5:43 PM · Frameworks
aleksejshilin updated the summary of D8958: Fix unintentional breadcrumb menu item activation.
Feb 23 2018, 5:35 PM · Frameworks

Feb 19 2018

aleksejshilin added a comment to D8958: Fix unintentional breadcrumb menu item activation.

Instead of the bool member, isn't it enough to test the distance again in mouseReleaseEvent? AFAIK that's how most widget do it. It also leads to one difference of behaviour in case someone moves the mouse a bit and then back to the original position, in that case the mouseReleaseEvent considers that no move happened (not sure if that's what you want here).

Feb 19 2018, 3:04 AM · Frameworks

Feb 17 2018

aleksejshilin added a reviewer for D8958: Fix unintentional breadcrumb menu item activation: dfaure.
Feb 17 2018, 1:47 AM · Frameworks

Feb 13 2018

aleksejshilin added a comment to D10478: messagelist: Save current selection at exit.

Do you want that I commit it for you ?

Feb 13 2018, 12:45 PM · KDE PIM
aleksejshilin updated the diff for D10478: messagelist: Save current selection at exit.
  • Use proper coding style
Feb 13 2018, 10:40 AM · KDE PIM
aleksejshilin added inline comments to D10478: messagelist: Save current selection at exit.
Feb 13 2018, 10:34 AM · KDE PIM
aleksejshilin requested review of D10478: messagelist: Save current selection at exit.
Feb 13 2018, 7:07 AM · KDE PIM

Feb 10 2018

aleksejshilin added a comment to D10417: messagelist: Fix default aggregation and theme inconstancy.

Thanks!
Please note that I don't have a Developer Account and hence am unable to push the changes myself.

Feb 10 2018, 8:52 PM · KDE PIM
aleksejshilin added a comment to D8958: Fix unintentional breadcrumb menu item activation.

OK cool. The patch works for me! +1.

Feb 10 2018, 3:35 PM · Frameworks
aleksejshilin added inline comments to D8958: Fix unintentional breadcrumb menu item activation.
Feb 10 2018, 2:43 PM · Frameworks
aleksejshilin updated the diff for D8958: Fix unintentional breadcrumb menu item activation.

Rebase on master

Feb 10 2018, 2:23 PM · Frameworks
aleksejshilin added a comment to D8958: Fix unintentional breadcrumb menu item activation.

Hi again. :)
Any news on this? Is there anything I should improve?

Feb 10 2018, 1:39 PM · Frameworks

Feb 9 2018

aleksejshilin requested review of D10417: messagelist: Fix default aggregation and theme inconstancy.
Feb 9 2018, 9:13 PM · KDE PIM

Dec 8 2017

aleksejshilin added a comment to D8958: Fix unintentional breadcrumb menu item activation.

So, any comments on the updated revision?

Dec 8 2017, 7:37 AM · Frameworks

Nov 24 2017

aleksejshilin updated the diff for D8958: Fix unintentional breadcrumb menu item activation.
  • Don't consider mouse moves which are smaller than drag distance
  • Don't pass the ignored mouse release event to the base class
Nov 24 2017, 1:52 AM · Frameworks

Nov 23 2017

aleksejshilin created D8958: Fix unintentional breadcrumb menu item activation.
Nov 23 2017, 12:05 AM · Frameworks

Oct 27 2017

aleksejshilin added a comment to D8502: Fix brightness not restoring when an inhibition is active.

@broulik @ngraham
Many thanks!

Oct 27 2017, 2:31 PM · Plasma
aleksejshilin added a comment to D8502: Fix brightness not restoring when an inhibition is active.

I bet there's a bug report on Bugzilla about this.

Oct 27 2017, 11:49 AM · Plasma

Oct 26 2017

aleksejshilin added a comment to D8502: Fix brightness not restoring when an inhibition is active.

I've created a script to demonstrate the issue (attached). It uses VLC to acquire inhibition after the screen is dimmed.

Oct 26 2017, 4:10 PM · Plasma
aleksejshilin created D8502: Fix brightness not restoring when an inhibition is active.
Oct 26 2017, 4:03 PM · Plasma

Oct 23 2017

aleksejshilin added a comment to D8397: Align logout screen action buttons to the top.

I don't have push access, so could you do that for me, please? :)
I've attached the original diff made with 'git format-patch' for your convenience.

Oct 23 2017, 1:01 PM · Plasma

Oct 21 2017

aleksejshilin created D8397: Align logout screen action buttons to the top.
Oct 21 2017, 12:55 PM · Plasma