Differential D13867

[KMessageWidget] Pass widget to standardIcon()
ClosedPublic
Actions

Authored by broulik on Jul 3 2018, 11:01 AM.

Details

Reviewers
cfeck
ngraham
dhaumann
Group Reviewers
Frameworks
Commits
R236:dbee23dd939b: [KMessageWidget] Pass widget to standardIcon()
Summary

This way the style knows what widget the icon is placed in and could do something different.

Test Plan

Compiles, Breeze now knows it's a KMessageWidget

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 3 2018, 11:01 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 3 2018, 11:01 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jul 3 2018, 11:01 AM
cfeck added inline comments.Jul 3 2018, 11:49 AM
src/kmessagewidget.cpp
94 ↗(On Diff #37101)

Could also pass a QStyleOption, initialized from the widget.

broulik planned changes to this revision.Oct 10 2018, 2:04 PM
broulik updated this revision to Diff 61989.Jul 18 2019, 4:14 PM
  • Pass QStyleOption
cfeck accepted this revision.Jul 18 2019, 7:48 PM
This revision is now accepted and ready to land.Jul 18 2019, 7:48 PM
dhaumann accepted this revision.Jul 18 2019, 9:18 PM
dhaumann added a subscriber: dhaumann.

The commit log says "Breeze now knows it's a KMessageWidget". Ok. And now? The commit log lacks what issue this patch fixes...

Besides that, looks good to me.

Closed by commit R236:dbee23dd939b: [KMessageWidget] Pass widget to standardIcon() (authored by broulik). · Explain WhySep 2 2019, 10:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmessagewidget.cpp (5 lines)

Diff 61989

View Options

src/kmessagewidget.cpp

Loading...