OutputManagement fractional scaling
ClosedPublic

Authored by davidedmundson on Jun 19 2018, 10:46 AM.

Details

Summary

In order to have fractional scaling in kwin, we need to communicate it with
kscreen, which means changing the data type in our config protocols.

This introduces a new method on outputdevice and outputconfiguration
to set/request scale as a float.

wl_output is and should remain unchanged as an int

No urgent rush for reviewing/merging this as it's useless without other changes.

Test Plan

Attached unit tests

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 19 2018, 10:46 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jun 19 2018, 10:46 AM
zzag added a subscriber: zzag.Jun 19 2018, 11:31 AM
zzag added inline comments.
src/server/outputconfiguration_interface.cpp
194

Nitpick: can be const. :-)

zzag added inline comments.Jun 22 2018, 1:11 PM
src/client/outputdevice.cpp
413

Extra new line.

src/server/outputconfiguration_interface.cpp
73

wl_resource is one space off.

src/server/outputdevice_interface.cpp
511

Extra new line.

whitespace changes

romangg added inline comments.
src/server/outputdevice_interface.cpp
448

The macro does not do a fuzzy compare.

src/server/outputdevice_interface.h
138

You mean: scaleFChanged(qreal) ?

140

This signal is never used (neither connected in the constructor nor emitted in the macro).

romangg requested changes to this revision.Jun 23 2018, 11:59 AM
This revision now requires changes to proceed.Jun 23 2018, 11:59 AM
davidedmundson marked 2 inline comments as done.

qFuzzyCompare

(not sure it's relevant as the comparison it makes is greater than
the resolution of wl_fixed, but whatever)

qFuzzyCompare

Also emit scale changed when scaleF changes

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2018, 4:05 PM
This revision was automatically updated to reflect the committed changes.