Differential D13730

Fix memory management in WaylandOutputManagement
ClosedPublic
Actions

Authored by davidedmundson on Jun 25 2018, 11:50 PM.

Details

Reviewers

romangg

Group Reviewers

KWin

Commits

R127:baba76289560: Fix memory management in WaylandOutputManagement

Summary

There was no destructor in the protocol, which meant the auto generated
_destroy function only deletes the wl_proxy object, but doesn't actually
send anything to the server.

Result was OutputConfiguration objects on
the server just linger forever and it's a broken state

Test Plan

Added unit test that objects have the lifespan they should do

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Jun 25 2018, 11:50 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJun 25 2018, 11:50 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

davidedmundson requested review of this revision.Jun 25 2018, 11:50 PM

Harbormaster completed remote builds in B314: Diff 36663.Jun 25 2018, 11:50 PM

This seems to depend on D13601 because of the scaleFCallback.

This revision is now accepted and ready to land.Jul 2 2018, 9:01 AM

Closed by commit R127:baba76289560: Fix memory management in WaylandOutputManagement (authored by davidedmundson). · Explain WhyAug 5 2018, 4:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/client/test_wayland_outputmanagement.cpp (21 lines)
M			src/client/protocols/output-management.xml (4 lines)
M			src/server/outputconfiguration_interface.cpp (3 lines)